Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating App Gateway Subnet Range to /24 #264

Merged
merged 2 commits into from
May 11, 2022
Merged

Updating App Gateway Subnet Range to /24 #264

merged 2 commits into from
May 11, 2022

Conversation

TIGHEDEV
Copy link
Contributor

@TIGHEDEV TIGHEDEV commented May 11, 2022 •
edited
Loading

PR Summary

Closes #256

Changed App Gateway default subnet range to /24 instead of /26

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@TIGHEDEV TIGHEDEV temporarily deployed to csu May 11, 2022 15:27 Inactive
@TIGHEDEV TIGHEDEV temporarily deployed to azurecirgs May 11, 2022 15:27 Inactive
@TIGHEDEV TIGHEDEV changed the title Tibrenna Updating App Gateway Subnet Range to /24 May 11, 2022
github-actions[bot]
github-actions bot reviewed May 11, 2022
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, one of the team will evaluate shortly.

@Gordonby Gordonby added secure-baseline Relates to Secure Baseline Architecture test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge well-architected Relates to the Well Architected Framework and removed helper-ui labels May 11, 2022
@TIGHEDEV TIGHEDEV enabled auto-merge May 11, 2022 15:29
Gordonby
Gordonby approved these changes May 11, 2022
View reviewed changes
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TIGHEDEV TIGHEDEV merged commit d9ccee3 into main May 11, 2022
@TIGHEDEV TIGHEDEV deleted the tibrenna branch May 11, 2022 15:36
@Gordonby Gordonby added the helper-bicep-link 🧙‍♂️ Issue in the leveraging of the bicep label May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@Gordonby Gordonby Gordonby approved these changes

Assignees

@TIGHEDEV TIGHEDEV

Labels
helper-bicep-link 🧙‍♂️ Issue in the leveraging of the bicep secure-baseline Relates to Secure Baseline Architecture test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge well-architected Relates to the Well Architected Framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase the default size of the subnet for Application Gateway
2 participants
@TIGHEDEV @Gordonby