Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped in Terraform - preview [2] #279

Merged
merged 1 commit into from
May 19, 2022
Merged

Wrapped in Terraform - preview [2] #279

merged 1 commit into from
May 19, 2022

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented May 19, 2022 •
edited
Loading

PR Summary

Extends #272

Suggestions from Paolo

  • Moves Resource Group Name to variables
  • More specific provider versioning requirements
  • Descriptions to be added to outputs

Bug fixes

  • PrincipalId based parameters need to be wrapped in a {value=} format.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress

@Gordonby Gordonby requested a review from khowling May 19, 2022 11:09
@Gordonby Gordonby self-assigned this May 19, 2022
@Gordonby Gordonby enabled auto-merge May 19, 2022 11:09
@Gordonby Gordonby merged commit 8775a70 into main May 19, 2022
@Gordonby Gordonby deleted the gb-tfIterate branch May 19, 2022 11:28
@Gordonby Gordonby mentioned this pull request May 20, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimPaine JimPaine JimPaine approved these changes

@khowling khowling Awaiting requested review from khowling

Assignees

@Gordonby Gordonby

Labels
helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gordonby @JimPaine