Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Seamless Post Deploy UI experience and reusable workflow for app repos #283

Merged
merged 85 commits into from
Jul 11, 2022

Conversation

khowling
Copy link
Contributor

@khowling khowling commented May 20, 2022

PR Summary

Provides a simple full deploy experiance, including provisioning the cluster & the post deploy helm/kubectl in a script file that is called from UI and github deployments.

Complete:

  • Extract ALL post deploy scripts from the react components into post-deploy separate bash script
  • Externalize the versioning of all external dependencies (external-dns, grafana etc) in ./helper/src/dependencies.json & add to release. This ensures that consistent versions of all dependences are controlled and used everywhere (UI, actions, validations, tests etc)
  • Extract all az cli commands out of post-deploy and move into bicep (importing 3rd party images into ACR & is the AGIC/boyvnet workaround still required with the latest release??)
  • Implement importing images used by dependencies into ACR, to allow closer firewall rules. All the logic is in place for this, however, need to complete the config for all dependencies, and close the firewall rules (and maybe provide a specific option for this in the UI, ie open firewall or import images)
  • Update the UI to have a single copy command for the complete deployment & post deploy (ideally in future PRs, have the postdeploy script called directly by the bicep template to further simplify the cli)
  • Create a reusable workflow that can be called by the sample app repos to create a cluster to that apps specification
  • Add a github tab to the deployment, with easy instructions on how to incorporate your cluster provisioning workflow into your workload repo using the new federated identity

Other fixes

  • Fix the URL parameters for scaling (scaling wasn't being saved)
  • Fix the bicep parameters for autoscale (autoscale 'agentCountMax' was not being passed to bicep from the landing default config)

For another PR

  • Update the Java sample to use the reusable workflow, and update the samples tab in this repo (maybe iframe?)

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@khowling khowling temporarily deployed to azurecirgs May 20, 2022 11:51 Inactive
@khowling
Copy link
Contributor Author

khowling commented May 20, 2022

The postdeploy.sh needs to be tested in a number of running scenarios, I want it to work in:

  1. Run directly from a local cloned repo (when testing)
  2. Run from the complied bicep template (when used from the helper)
  3. Called from a runner (when used in CI/CD)
  4. Run from a desired state solution (GitOps) (Future PR)

In each of the above scenarios, it needs to work with

  1. Private clusters (It needs to import all 3rd party containers into ACR)
  2. public clusters

@khowling khowling changed the title postdeploy A Seamless Post Deploy May 20, 2022
@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Jun 20, 2022
@khowling khowling temporarily deployed to azurecirgs June 23, 2022 21:10 Inactive
@khowling khowling temporarily deployed to azurecirgs June 23, 2022 21:21 Inactive
@khowling khowling changed the title A Seamless Post Deploy A Seamless Post Deploy UI experiance and resuable workflow for app repos Jun 23, 2022
@khowling khowling temporarily deployed to azurecirgs June 25, 2022 22:50 Inactive
@khowling khowling temporarily deployed to csu June 25, 2022 22:50 Inactive
@khowling khowling temporarily deployed to azurecirgs June 25, 2022 22:50 Inactive
@khowling khowling temporarily deployed to csu June 26, 2022 22:10 Inactive
@khowling khowling temporarily deployed to azurecirgs June 26, 2022 22:10 Inactive
@khowling khowling temporarily deployed to csu June 27, 2022 11:19 Inactive
@khowling khowling temporarily deployed to azurecirgs June 27, 2022 11:19 Inactive
@khowling khowling temporarily deployed to csu June 28, 2022 16:20 Inactive
@khowling khowling temporarily deployed to azurecirgs June 28, 2022 16:20 Inactive
CI/CD - Leveraging new reusable workflow in Standard repo deployment
@khowling khowling temporarily deployed to azurecirgs July 6, 2022 14:01 Inactive
@Gordonby Gordonby temporarily deployed to azurecirgs July 6, 2022 14:11 Inactive
@Gordonby Gordonby temporarily deployed to csu July 6, 2022 14:11 Inactive
@Gordonby Gordonby temporarily deployed to csu July 6, 2022 14:12 Inactive
@Gordonby Gordonby temporarily deployed to csu July 6, 2022 14:15 Inactive
@khowling khowling temporarily deployed to azurecirgs July 6, 2022 14:37 Inactive
@Gordonby Gordonby changed the title A Seamless Post Deploy UI experiance and resuable workflow for app repos A Seamless Post Deploy UI experience and reusable workflow for app repos Jul 6, 2022
@Gordonby Gordonby temporarily deployed to azurecirgs July 8, 2022 12:10 Inactive
@khowling khowling temporarily deployed to azurecirgs July 8, 2022 12:13 Inactive
@khowling khowling temporarily deployed to azurecirgs July 8, 2022 12:20 Inactive
@Gordonby Gordonby temporarily deployed to csu July 8, 2022 12:20 Inactive
@Gordonby Gordonby temporarily deployed to csu July 8, 2022 12:22 Inactive
@Gordonby Gordonby temporarily deployed to csu July 8, 2022 12:28 Inactive
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot Scale cluster provisioned with omsagent=false
2 participants