Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Deployment Helper web ui failure #327

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix for Deployment Helper web ui failure #327

merged 1 commit into from
Jul 18, 2022

Conversation

khowling
Copy link
Contributor

@khowling khowling commented Jul 18, 2022 •
edited
Loading

PR Summary

If explicitly setting the UI release version to use (setting REACT_APP_TEMPLATERELEASE during UI build-time). Add validation to ensure the required release version exists and is valid.

In addition, add the missing depednecies.json file to release matrix

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@khowling
Copy link
Contributor Author

#321

@khowling
Copy link
Contributor Author

Instead of blank screen, now get:
image

Gordonby
Gordonby approved these changes Jul 18, 2022
View reviewed changes
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gordonby
Copy link
Collaborator

Closes #321

@khowling khowling merged commit 0b2ccda into main Jul 18, 2022
@khowling khowling deleted the kh-hotfix-uierror branch July 18, 2022 15:04
@Gordonby Gordonby mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gordonby Gordonby Gordonby approved these changes

Assignees

@khowling khowling

Labels
helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khowling @Gordonby