Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PowerShell Deployment Option to the Helper #528

Merged
merged 12 commits into from
Jun 29, 2023

Conversation

fireblade95402
Copy link
Contributor

@fireblade95402 fireblade95402 commented Feb 20, 2023

PR Summary

Added deployment option for PowerShell. Decided to to NOT change the az cli commands to PowerShell and only really change the postdeploy.sh script to postdeploy.ps1. I needed to change syntax in the helper and the release action to add in the new script, plus logic the handle old releases where the postdeplo.ps1 isn't available.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)
    image

@fireblade95402 fireblade95402 linked an issue Feb 20, 2023 that may be closed by this pull request
@fireblade95402 fireblade95402 changed the title Mwg powershell helper 2 Adding PowerShell Deployment Option to the Helper Feb 20, 2023
@fireblade95402
Copy link
Contributor Author

Need to check with the team on any functionality that might have been missed

@Gordonby Gordonby added the enhancement New feature or request label Feb 20, 2023
@Gordonby
Copy link
Collaborator

The tab is disabled for me.
Is that expected?

image

@fireblade95402
Copy link
Contributor Author

@Gordonby It has logic to disable the PowerShell tab if the postdeploy.ps1 isn't in the release. So need a release to test it out.

@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label May 13, 2023
@khowling
Copy link
Contributor

khowling commented Jun 1, 2023

Mark, I've setup a review meeting to discuss, things I want to check is to ensure it works with private clusters, and local testing. And to ensure we have some test coverage in the actions.

@github-actions github-actions bot added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Jun 1, 2023
@fireblade95402 fireblade95402 marked this pull request as ready for review June 29, 2023 09:31
@Gordonby
Copy link
Collaborator

Gordonby commented Jun 29, 2023

I'm getting an error when running this command

az deployment group create -g gordons  --template-file ./bicep/main.bicep --parameters `
resourceName=az-k8s-krcu `
SystemPoolType=Standard `
availabilityZones='["1","2\",\"3"]'
InvalidAvailabilityZoneFormat

The specified Availability Zones [1 2\\\",\\\"3] are invalid and should be in numeric format.

image

    "error": {
        "code": "InvalidAvailabilityZoneFormat",
        "target": "agentPoolProfile.availabilityZone",
        "message": "The specified Availability Zones [1 2\",\"3] are invalid and should be in numeric format."
    }

@Gordonby Gordonby added the test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge label Jun 29, 2023
Copy link
Collaborator

@Gordonby Gordonby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fireblade95402 fireblade95402 merged commit 7595d0d into main Jun 29, 2023
8 checks passed
@fireblade95402 fireblade95402 deleted the mwg-powershell-helper-2 branch June 29, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helper-ui Keep Open test-deploy-privateconfig A PR flag to make sure that the Private deployment is run before merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Powershell script in Deployment Helper
3 participants