Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix for preview modal #601

Merged
merged 6 commits into from
Jun 30, 2023
Merged

bugfix for preview modal #601

merged 6 commits into from
Jun 30, 2023

Conversation

nellyk
Copy link
Member

@nellyk nellyk commented Jun 26, 2023

PR Summary

This resolve a bug that made the preview popup not close when switching tabs.

To add an preview Dialog, add an function on the onChange activity for example:

onChange={(ev, v) => {updateFn("acrUntaggedRetentionPolicyEnabled", v); showPreviewModal(ev,"https://learn.microsoft.com/en-us/azure/container-registry/container-registry-retention-policy"); }}

adding function with the link to the preview page:-

showPreviewModal(event,"link to preview page")

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)
    previewdialog

Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for this, looking really good. I have a few comments I'd like to chat about before approval.

helper/src/components/portalnav.js Outdated Show resolved Hide resolved
helper/src/components/previewDialog.js Outdated Show resolved Hide resolved
helper/src/components/previewDialog.js Show resolved Hide resolved
helper/src/components/portalnav.js Show resolved Hide resolved
helper/src/components/addonsTab.js Show resolved Hide resolved
@Gordonby Gordonby requested a review from khowling June 29, 2023 14:54
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Nellyk, looks great!

@Gordonby Gordonby merged commit 7e4eb18 into main Jun 30, 2023
33 checks passed
@Gordonby Gordonby deleted the feat/dialog-for-previews-bugfix branch June 30, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants