Azure/personal/dns warning #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palashvij-msft
force-pushed
the
Azure/personal/dns_warning
branch
2 times, most recently
from
6202902
to
a12d9da
Compare
linuxsmiths
reviewed
Aug 25, 2023
src/mountscript.sh
Outdated
Comment on lines
642
to
647
| if is_present_in_etc_hosts "$nfs_host"; then | ||
| eecho "Mount failed!" | ||
| eecho "Detected entry for $nfs_host in /etc/hosts." | ||
| eecho "[Action Required]: Remove or comment out the entry for $nfs_host in /etc/hosts for MOUNT to work." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
we need to be very careful that we don't raise a red flag, so let's first resolve the IP and then check for the entire
IP[[:space:]]+fqdn so that we only complain when user has set the resolver config such that the address is resolving from /etc/hosts.
linuxsmiths
reviewed
Sep 7, 2023
linuxsmiths
reviewed
Sep 7, 2023
linuxsmiths
reviewed
Sep 7, 2023
linuxsmiths
reviewed
Sep 7, 2023
lib/common.sh
Outdated
Comment on lines
237
to
243
| eecho "[FATAL] Detected entry $ipv4_addr $hname in /etc/hosts." | ||
| eecho "$hname is resolving into $ipv4_addr from /etc/hosts." | ||
| eecho "Remove the entry for "$hname" in /etc/hosts to ensure proper handling of endpoint IP address changes by AZNFS." | ||
| return 1 | ||
| else | ||
| wecho "[FATAL] Detected entry $ipv4_addr $hname in /etc/hosts." 1>/dev/null | ||
| wecho "Remove the entry for "$hname" in /etc/hosts to ensure proper handling of endpoint IP address changes by AZNFS." 1>/dev/null |
There was a problem hiding this comment.
remove dot at the end of each log, we don't add dot at the end of logs in other places, isn't it?
also why do you want to suppress log coming on stdout at L242 243, let it come on stdout
There was a problem hiding this comment.
Here, I have suppressed the this log, as otherwise value of new_ip in aznfswatchdog gets updated to this error log
L 315: new_ip=$(resolve_ipv4 "$l_host" "false").
linuxsmiths
reviewed
Sep 7, 2023
linuxsmiths
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.