Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users/v muuppugund/cloud data connector #9651

Merged
merged 5 commits into from
Mar 18, 2024

Conversation

v-muuppugund
Copy link
Contributor

@v-muuppugund v-muuppugund commented Dec 21, 2023

Required items, please complete

Change(s):

  • Standard tier is removed from Azure security center data connector as its obsolete

Reason for Change(s):

Version Updated:
-3.0.1

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@v-sudkharat
Copy link
Contributor

Hi @v-muuppugund, thank you for raising PR by adding changes, as discussed please add testing completed screenshot in PR itself. Thanks!

@v-sudkharat
Copy link
Contributor

v-sudkharat commented Jan 11, 2024

@v-muuppugund, 1- Please update the release notes path in create ui file -
image

2- Description for both the connector looks same, please check on it -
image

  1. After deployment of solution the Tenant-based Microsoft Defender for Cloud (Preview) corrector is not redirecting connector instruction page-
    image

I have checked the data file and found that this connector is 1P - true -
image

Please check on this. Thanks!

@v-muuppugund v-muuppugund marked this pull request as draft February 13, 2024 06:16
@v-muuppugund v-muuppugund marked this pull request as ready for review March 18, 2024 05:54
Copy link
Contributor

@v-sudkharat v-sudkharat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks Good.

@v-atulyadav v-atulyadav merged commit ee18dca into master Mar 18, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content-Package Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Defender for Cloud Data Connector doc conflict on requirement for sub-level plans
3 participants