Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] when do we start/stop actually using the camera? #79

Closed
terrychen1122 opened this issue Oct 27, 2020 · 1 comment
Closed

[iOS] when do we start/stop actually using the camera? #79

terrychen1122 opened this issue Oct 27, 2020 · 1 comment
Labels
Calling Issue involves Calling functionality. Documentation Improvements or additions to documentation iOS Issues involving the iOS SDK Needs: attention 👋

Comments

@terrychen1122
Copy link

Since iOS14, Apple will display an indicator on the status bar for camera usage. I am curious which of the following steps we start using the camera (to make sure we do the right thing at the right timing and step):

  1. When ACSDeviceManager is created by ACSCallClient
  2. When a ACSLocalVideoStream is initialized by a video device info from the device manager
  3. When a ACSRenderer is initialized by a local video stream
  4. When a ACSRendererView is initialized by a ACSRenderer that is created by a local video stream

My guess is #2 since I saw exception if I didn't grant permission when doing 2 (but it could also be 3 or 4). Since I don't have Xcode 12 installed locally, it will take some time for us to verify. So, I would just ask here to confirm.

Thanks

@ghost ghost added the Needs: triage 🔍 label Oct 27, 2020
@RinaRish RinaRish added Calling Issue involves Calling functionality. Documentation Improvements or additions to documentation and removed Needs: triage 🔍 labels Oct 27, 2020
@xixian73
Copy link
Contributor

#2 throws exception because we can't read camera settings without it.

#4 is when the camera is actually opened and iOS will start showing the indicator in status bar for camera usage and it will stay like that unless the app invokes ACSRenderer.dispose()

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
@mariusu-msft mariusu-msft added the iOS Issues involving the iOS SDK label Dec 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Calling Issue involves Calling functionality. Documentation Improvements or additions to documentation iOS Issues involving the iOS SDK Needs: attention 👋
Projects
None yet
Development

No branches or pull requests

5 participants