Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ACS sample app group call #2

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Adding ACS sample app group call #2

merged 2 commits into from
Jul 29, 2020

Conversation

armansabaa
Copy link
Contributor

@armansabaa armansabaa commented Jul 28, 2020 •
edited
Loading

Moving Calling Sample code.

DominikMe
DominikMe reviewed Jul 28, 2020
View reviewed changes
samples/js/ACS_Calling_Sample/NOTICES.txt
@@ -0,0 +1,10509 @@
THIRD PARTY SOFTWARE NOTICES AND INFORMATION
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this get generated automatically somehow?

@DominikMe
Copy link
Member

Is there a LICENSE for the sample? (MIT?)

DominikMe
DominikMe approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@DominikMe DominikMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, some suggestions that should be quick to fix but not blocking

@armansabaa armansabaa merged commit a960100 into master Jul 29, 2020
@armansabaa armansabaa deleted the adding_calling_sample branch July 30, 2020 02:49
@shipon-eye shipon-eye mentioned this pull request Oct 20, 2020
Closed
@terrychen1122 terrychen1122 mentioned this pull request Oct 27, 2020
Closed
@shipon-eye shipon-eye mentioned this pull request Jan 8, 2021
Closed
@iaulakh iaulakh mentioned this pull request Jun 30, 2021
Open
jsaurezlee-msft added a commit that referenced this pull request Aug 12, 2021
@jsaurezlee-msft
Merge pull request #2 from jsaurezlee-msft/master
832d8d2 
Merge pull request #1 from Azure/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alex-kwan alex-kwan alex-kwan approved these changes

@DominikMe DominikMe DominikMe approved these changes

@tophpalmer tophpalmer tophpalmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@armansabaa @DominikMe @alex-kwan @tophpalmer