Skip to content

Commit

Permalink
[PSRule] Public Ip addresses (#3998)
Browse files Browse the repository at this point in the history
* updated public IP default sku

* updated json and supress PSrule availability zones

---------

Co-authored-by: Elena Batanero Garcia <elbatane@microsoft.com>
  • Loading branch information
elbatane and elenabatanero authored Sep 22, 2023
1 parent 5c2b0e0 commit 709cf41
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 13 deletions.
13 changes: 7 additions & 6 deletions .ps-rule/min-suppress.Rule.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,13 @@ metadata:
name: 'SuppressMin'
spec:
rule:
- Azure.Resource.UseTags
- Azure.KeyVault.Logs
- Azure.KeyVault.Firewall
- Azure.Policy.ExemptionDescriptors
- Azure.Policy.Descriptors
- Azure.Policy.AssignmentDescriptors
- Azure.Resource.UseTags
- Azure.KeyVault.Logs
- Azure.KeyVault.Firewall
- Azure.Policy.ExemptionDescriptors
- Azure.Policy.Descriptors
- Azure.Policy.AssignmentDescriptors
- Azure.PublicIP.AvailabilityZone
if:
name: '.'
contains:
Expand Down
2 changes: 1 addition & 1 deletion modules/network/public-ip-address/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ This module deploys a Public IP Address.
| `publicIPPrefixResourceId` | string | `''` | | Resource ID of the Public IP Prefix object. This is only needed if you want your Public IPs created in a PIP Prefix. |
| `reverseFqdn` | string | `''` | | The reverse FQDN. A user-visible, fully qualified domain name that resolves to this public IP address. If the reverseFqdn is specified, then a PTR DNS record is created pointing from the IP address in the in-addr.arpa domain to the reverse FQDN. |
| `roleAssignments` | array | `[]` | | Array of role assignment objects that contain the 'roleDefinitionIdOrName' and 'principalId' to define RBAC role assignments on this resource. In the roleDefinitionIdOrName attribute, you can provide either the display name of the role definition, or its fully qualified ID in the following format: '/providers/Microsoft.Authorization/roleDefinitions/c2f4ef07-c644-48eb-af81-4b1b4947fb11'. |
| `skuName` | string | `'Basic'` | `[Basic, Standard]` | Name of a public IP address SKU. |
| `skuName` | string | `'Standard'` | `[Basic, Standard]` | Name of a public IP address SKU. |
| `skuTier` | string | `'Regional'` | `[Global, Regional]` | Tier of a public IP address SKU. |
| `tags` | object | `{object}` | | Tags of the resource. |
| `zones` | array | `[]` | | A list of availability zones denoting the IP allocated for the resource needs to come from. |
Expand Down
2 changes: 1 addition & 1 deletion modules/network/public-ip-address/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ param publicIPAllocationMethod string = 'Dynamic'
'Basic'
'Standard'
])
param skuName string = 'Basic'
param skuName string = 'Standard'

@description('Optional. Tier of a public IP address SKU.')
@allowed([
Expand Down
10 changes: 5 additions & 5 deletions modules/network/public-ip-address/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "7444990895328873286"
"version": "0.21.1.54444",
"templateHash": "4549627603480081601"
},
"name": "Public IP Addresses",
"description": "This module deploys a Public IP Address.",
Expand Down Expand Up @@ -38,7 +38,7 @@
},
"skuName": {
"type": "string",
"defaultValue": "Basic",
"defaultValue": "Standard",
"allowedValues": [
"Basic",
"Standard"
Expand Down Expand Up @@ -338,8 +338,8 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "11249227806125160411"
"version": "0.21.1.54444",
"templateHash": "7328126239184883887"
}
},
"parameters": {
Expand Down

0 comments on commit 709cf41

Please sign in to comment.