Skip to content

Commit

Permalink
[Modules] ML - Wait on Private Endpoints before creating compute inst…
Browse files Browse the repository at this point in the history
…ances (#3715)

* wait on PeP before creating compute

* fix private end-point

* reset pep

* change pep

* update version

* update readme

* fix json

* fix json

* update mls json

* update documents

* reset settings

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
  • Loading branch information
Sdelausnay and AlexanderSehr authored Sep 4, 2023
1 parent 8115aae commit 95e677a
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
3 changes: 3 additions & 0 deletions modules/machine-learning-services/workspace/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@ module workspace_computes 'compute/main.bicep' = [for compute in computes: {
computeType: compute.computeType
properties: contains(compute, 'properties') ? compute.properties : {}
}
dependsOn: [
workspace_privateEndpoints
]
}]

resource workspace_lock 'Microsoft.Authorization/locks@2020-05-01' = if (!empty(lock)) {
Expand Down
9 changes: 5 additions & 4 deletions modules/machine-learning-services/workspace/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "12489776525535905441"
"templateHash": "9807343240175832898"
},
"name": "Machine Learning Services Workspaces",
"description": "This module deploys a Machine Learning Services Workspace.",
Expand Down Expand Up @@ -634,7 +634,8 @@
}
},
"dependsOn": [
"[resourceId('Microsoft.MachineLearningServices/workspaces', parameters('name'))]"
"[resourceId('Microsoft.MachineLearningServices/workspaces', parameters('name'))]",
"workspace_privateEndpoints"
]
},
{
Expand Down Expand Up @@ -683,7 +684,7 @@
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "13560297539192628062"
"templateHash": "16616509457944914829"
},
"name": "Private Endpoints",
"description": "This module deploys a Private Endpoint.",
Expand Down Expand Up @@ -883,7 +884,7 @@
"_generator": {
"name": "bicep",
"version": "0.20.4.51522",
"templateHash": "17831763001460207830"
"templateHash": "18114841529204248478"
},
"name": "Private Endpoint Private DNS Zone Groups",
"description": "This module deploys a Private Endpoint Private DNS Zone Group.",
Expand Down

0 comments on commit 95e677a

Please sign in to comment.