-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Modules] New Microsoft.Compute/sshPublicKey #2673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderSehr
changed the title
[Module] New Microsoft.Compute/sshPublicKey
[Modules] New Microsoft.Compute/sshPublicKey
Feb 9, 2023
modules/Microsoft.Compute/sshPublicKeys/.test/.scripts/New-SshPubKey.ps1
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/sshPublicKeys/.test/common/dependencies.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/sshPublicKeys/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/sshPublicKeys/.test/common/deploy.test.bicep
Outdated
Show resolved
Hide resolved
modules/Microsoft.Compute/sshPublicKeys/.test/min/deploy.test.bicep
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…ies.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…st.bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…bicep Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new module to generate a ssh Public Key. I cannot generate a status badge because I am unable to register the new workflow after resetting my main branch to the upstream commit, but the static tests and deployment tests worked successfully.
This resource is strange in that it really has no value. You cannot use this resource to generate an actual public key value. You must provide the public key string in the publicKey parameter if you want the resource to contain an actual public key.
The common test uses a deployment script to generate a temporary ssh public key via the 'New-AzSshKey' cmdlet and grab the public key string from this object to provide it as the publicKey parameter value.
Type of Change
Please delete options that are not relevant.
Checklist