Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] New Module: Network/ExpressRouteGateway for Virtual Hub Connectivity #2888

Merged
merged 23 commits into from
Apr 2, 2023

Conversation

fblix
Copy link
Contributor

@fblix fblix commented Mar 9, 2023

Description

Added Network/ExpressRouteGateway module.
This module contains functionality to be able to add an ExpressRoute gateway to an Azure Virtual Hub.
As described in #2458.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network - ExpressRouteGateway

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@fblix fblix added the [cat] modules category: modules label Mar 9, 2023
@fblix fblix requested a review from a team as a code owner March 9, 2023 14:26
@fblix fblix linked an issue Mar 9, 2023 that may be closed by this pull request
@fblix fblix changed the title Users/fblix jpeasier/express route gateway [Modules] New Module: Network/ExpressRouteGateway Mar 9, 2023
@fblix fblix changed the title [Modules] New Module: Network/ExpressRouteGateway [Modules] New Module: Network/ExpressRouteGateway for Virtual Hub Connectivity Mar 9, 2023
fblix and others added 3 commits March 13, 2023 16:02
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…loy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
fblix and others added 7 commits March 13, 2023 16:03
…loy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…loy.test.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
…endencies.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@github-actions
Copy link

Test Results

  1 files  ±0    1 suites  ±0   21s ⏱️ -3s
44 tests  - 2  40 ✔️  - 5  4 💤 +3  0 ±0 
44 runs   - 6  40 ✔️  - 8  4 💤 +2  0 ±0 

Results for commit 43bc38f. ± Comparison against base commit 8283179.

This pull request removes 46 and adds 44 tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.VirtualMachineImages/imageTemplates] used resource type [imageTemplates] should use one of the recent API version(s). Currently using [2022-02-14]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.VirtualMachineImages/imageTemplates] used resource type [locks] should use one of the recent API version(s). Currently using [2020-05-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.VirtualMachineImages/imageTemplates] used resource type [roleassignments] should use one of the recent API version(s). Currently using [2022-04-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.VirtualMachineImages/imageTemplates] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
…
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ API version tests.In [Microsoft.Network/expressRouteGateway] used resource type [expressRouteGateways] should use one of the recent API version(s). Currently using [2022-07-01]
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] All apiVersion properties should be set to a static, hard-coded value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] All non-required parameters in template file should not have description that start with "Required."
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] All parameters in parameters files exist in template file (deploy.json)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] All required parameters in template file (deploy.json) should exist in parameters files
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] CUA ID deployment should be present in the template
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] Conditional parameters' description should contain 'Required if' followed by the condition making the parameter required.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] Each parameters' description should start with a one word category starting with a capital letter, followed by a dot, a space and the actual description text ending with a dot.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] If delete lock is implemented, the template should have a lock parameter with an empty default value
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] Location output should be returned for resources that use it
…
This pull request removes 1 skipped test and adds 4 skipped tests. Note that renamed tests count towards both.
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.VirtualMachineImages/imageTemplates] JSON test files in the .test folder should be valid json
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] Resource ID output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] Resource name output should exist
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ Deployment template tests.General template.[Microsoft.Network/expressRouteGateway] Variable names should be camel-cased (no dashes or underscores and must start with lower-case letter)
/home/runner/work/ResourceModules/ResourceModules/utilities/pipelines/staticValidation/module.tests.ps1 ‑ File/folder tests..test folder.[Microsoft.Network/expressRouteGateway] JSON test files in the .test folder should be valid json

@fblix fblix requested a review from eriqua March 16, 2023 09:42
@eriqua eriqua added the enhancement New feature or request label Mar 31, 2023
@AlexanderSehr AlexanderSehr merged commit 0c5e38e into main Apr 2, 2023
@AlexanderSehr AlexanderSehr deleted the users/fblix-jpeasier/expressRouteGateway branch April 2, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: express route gateway for Hub Deployment
4 participants