Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] [BPR alignment] Rename deploy.bicep to main.bicep and deploy.test.bicep to main.test.bicep #3049

Merged
merged 24 commits into from
May 5, 2023

Conversation

eriqua
Copy link
Contributor

@eriqua eriqua commented Mar 26, 2023

Description

Closes #3133
Changes implemented to one module only to visualize/estimate work effort.

  • Pipeline utilities: Limited updates (more needed to script synopsis than to actual code)
  • Tests: Update needed for referenced modules
  • Bicep templates: Updates needed for referenced children
  • Workflows: No update needed (only to reusable workflow/template for publishing job)
  • Docs: Massive updates needed in docs

Update: extending to all modules and docs

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices - Servers
Storage - StorageAccounts
Authorization - RoleAssignments
DesktopVirtualization - HostPools
Build Status

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr
Copy link
Contributor

Note the depency on #2976

@eriqua eriqua changed the title [Modules] PoC - Rename deploy.bicep to main.bicep [Modules] [BPR alignment] PoC - Rename deploy.bicep to main.bicep Apr 23, 2023
@eriqua eriqua added documentation Improvements or additions to documentation [cat] pipelines category: pipelines [cat] modules category: modules [cat] github category: GitHub [cat] azure devops category: Azure DevOps [cat] testing category: testing labels May 5, 2023
@eriqua eriqua changed the title [Modules] [BPR alignment] PoC - Rename deploy.bicep to main.bicep [Modules] [BPR alignment] Rename deploy.bicep to main.bicep and deploy.test.bicep to main.test.bicep May 5, 2023
@eriqua eriqua changed the title [Modules] [BPR alignment] Rename deploy.bicep to main.bicep and deploy.test.bicep to main.test.bicep [Modules] [BPR alignment] Rename deploy.bicep to main.bicep and deploy.test.bicep to main.test.bicep May 5, 2023
@eriqua eriqua marked this pull request as ready for review May 5, 2023 15:45
@eriqua eriqua requested a review from a team as a code owner May 5, 2023 15:45
@eriqua eriqua merged commit 369cfb4 into main May 5, 2023
@eriqua eriqua deleted the users/erikag/bpr-mainbicep branch May 5, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] testing category: testing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PBR alignment] [Modules] Rename deploy.bicep and deploy.test.bicep Bicep files
2 participants