Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] ApplicationGateway - Adjusting sslPolicy based on policy type #3053

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Mar 28, 2023

Description

  • Adjusting sslPolicy property content to be based on policy type. When using predefined the sslPolicy property do only need name and type.

Kudos to @jayanchpd for finding the issue and solution.

Pipeline references

Pipeline
Network - ApplicationGateways

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@MariusStorhaug MariusStorhaug self-assigned this Mar 28, 2023
@MariusStorhaug MariusStorhaug added bug Something isn't working [cat] modules category: modules labels Mar 28, 2023
@MariusStorhaug MariusStorhaug changed the title Adjusting sslPolicy based on policy type [Modules] Adjusting sslPolicy based on policy type Mar 28, 2023
@MariusStorhaug MariusStorhaug changed the title [Modules] Adjusting sslPolicy based on policy type [Modules] ApplicationGateway - Adjusting sslPolicy based on policy type Mar 28, 2023
@MariusStorhaug MariusStorhaug marked this pull request as ready for review March 28, 2023 11:55
@MariusStorhaug MariusStorhaug requested a review from a team March 28, 2023 12:20
@MariusStorhaug MariusStorhaug merged commit 3c66b79 into main Mar 29, 2023
@MariusStorhaug MariusStorhaug deleted the users/mast/appgw_predefPol branch March 29, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working [cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants