New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated Blob Services for Storage Account Module to latest API and added new parameters #3100

Merged

ahmadabdalla merged 8 commits into main from users/ahmad/2994_storageBlob

Apr 9, 2023

Contributor

ahmadabdalla commented Apr 9, 2023

Description

Closes #2994

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

Checklist

I'm sure there are no other open Pull Requests for the same update/change
My corresponding pipelines / checks run clean and green without any errors or warnings
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation (readme)
I did format my code

ahmadabdalla added 6 commits

April 8, 2023 18:14


          updated blob service module

2aca0a8


          Merge remote-tracking branch 'origin/main' into users/ahmad/2994_stor…

346f46b

…ageBlob


          updated child modules

bf00860


          updated readme

84dc43a


          updates

51943a1


          Updated conditions

d6923cd

ahmadabdalla added enhancement [cat] modules labels

ahmadabdalla self-assigned this

ahmadabdalla marked this pull request as ready for review

April 9, 2023 02:13

ahmadabdalla requested a review from a team as a code owner

April 9, 2023 02:13

ahmadabdalla enabled auto-merge (squash)

April 9, 2023 02:14

ahmadabdalla added this to the Release v0.11.0 milestone

AlexanderSehr reviewed

View reviewed changes

.../Microsoft.Storage/storageAccounts/blobServices/containers/immutabilityPolicies/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Outdated Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Show resolved Hide resolved

AlexanderSehr reviewed

View reviewed changes

modules/Microsoft.Storage/storageAccounts/blobServices/deploy.bicep Outdated Show resolved Hide resolved

ahmadabdalla and others added 2 commits

April 9, 2023 17:32


          Apply suggestions from code review

9299d9e

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>


          Updated based on feedback

4f1a150

ahmadabdalla requested a review from AlexanderSehr

April 9, 2023 13:57

AlexanderSehr approved these changes

View reviewed changes

ahmadabdalla merged commit 4c5a453 into main

ahmadabdalla deleted the users/ahmad/2994_storageBlob branch

April 9, 2023 15:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[cat] modules enhancement