Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Added Public DNS Zone Module #3102

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

ahmadabdalla
Copy link
Contributor

@ahmadabdalla ahmadabdalla commented Apr 9, 2023

Closes #3070

  • Includes all child resource types
  • Updated RBAC nested assignments
  • Used the prefix 'Public' in the Workflows, pipelines, and documentation name to distinct this module from the 'Private DNS Zone' version

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network - Public DnsZones

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ahmadabdalla ahmadabdalla added enhancement New feature or request [cat] modules category: modules labels Apr 9, 2023
@ahmadabdalla ahmadabdalla added this to the Release v0.11.0 milestone Apr 9, 2023
@ahmadabdalla ahmadabdalla self-assigned this Apr 9, 2023
@ahmadabdalla ahmadabdalla marked this pull request as ready for review April 9, 2023 13:56
@ahmadabdalla ahmadabdalla requested a review from a team as a code owner April 9, 2023 13:56
@ahmadabdalla ahmadabdalla enabled auto-merge (squash) April 9, 2023 13:56
ahmadabdalla and others added 2 commits April 23, 2023 20:01
Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
@ahmadabdalla ahmadabdalla merged commit 1406723 into Azure:main Apr 25, 2023
@ahmadabdalla ahmadabdalla deleted the users/ahmad/3070_dnsZone branch April 27, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: module for Microsoft.Network/dnsZones
2 participants