Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Updated more parameters & added test case #3109

Merged
merged 1 commit into from
Apr 14, 2023
Merged

[Modules] Updated more parameters & added test case #3109

merged 1 commit into from
Apr 14, 2023

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Updated more parameters
  • Added test case

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
ContainerService - ManagedClusters
Compute - AvailabilitySets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner April 14, 2023 20:24
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Apr 14, 2023
@AlexanderSehr AlexanderSehr linked an issue Apr 14, 2023 that may be closed by this pull request
[Feature Request]: Reduce module parameter-names to their name without the modules identifier #2677
Closed
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 14, 2023 20:27
eriqua
eriqua approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 585d172 into main Apr 14, 2023
@AlexanderSehr AlexanderSehr deleted the users/alsehr/paramReduction branch April 14, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Reduce module parameter-names to their name without the modules identifier
2 participants
@AlexanderSehr @eriqua