Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] RSV backup fabrics new inner folder to comply with resource type hierarchy #3512

Merged
merged 6 commits into from
Aug 6, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/recovery-services/vaults/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ This module deploys a Recovery Services Vault.
| `lock` | string | `''` | `['', CanNotDelete, ReadOnly]` | Specify the type of lock. |
| `monitoringSettings` | object | `{object}` | | Monitoring Settings of the vault. |
| `privateEndpoints` | array | `[]` | | Configuration details for private endpoints. For security reasons, it is recommended to use private endpoints whenever possible. |
| `protectionContainers` | _[protectionContainers](protection-containers/README.md)_ array | `[]` | | List of all protection containers. |
| `protectionContainers` | array | `[]` | | List of all protection containers. |
| `publicNetworkAccess` | string | `'Disabled'` | `[Disabled, Enabled]` | Whether or not public network access is allowed for this resource. For security reasons it should be disabled. |
| `replicationAlertSettings` | _[replicationAlertSettings](replication-alert-settings/README.md)_ object | `{object}` | | Replication alert settings. |
| `replicationFabrics` | _[replicationFabrics](replication-fabrics/README.md)_ array | `[]` | | List of all replication fabrics. |
Expand Down
9 changes: 6 additions & 3 deletions modules/recovery-services/vaults/backup-config/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.19.5.34762",
"templateHash": "152163391701947893"
}
"version": "0.20.4.51522",
"templateHash": "2030776827393689599"
},
"name": "Recovery Services Vault Backup Config",
"description": "This module deploys a Recovery Services Vault Backup Config.",
"owner": "Azure/module-maintainers"
},
"parameters": {
"recoveryVaultName": {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Recovery Services Vault Protection Container `[Microsoft.RecoveryServices/vaults/protectionContainers]`
# Recovery Services Vault Protection Container `[Microsoft.RecoveryServices/vaults/backupFabrics/protectionContainers]`

This module deploys a Recovery Services Vault Protection Container.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.19.5.34762",
"templateHash": "10695770291439061865"
}
"version": "0.20.4.51522",
"templateHash": "17832840146797285516"
},
"name": "Recovery Services Vault Protection Container",
"description": "This module deploys a Recovery Services Vault Protection Container.",
"owner": "Azure/module-maintainers"
},
"parameters": {
"recoveryVaultName": {
Expand Down Expand Up @@ -169,9 +172,12 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.19.5.34762",
"templateHash": "9148923827539718769"
}
"version": "0.20.4.51522",
"templateHash": "6407898441503460857"
},
"name": "Recovery Service Vaults Protection Container Protected Item",
"description": "This module deploys a Recovery Services Vault Protection Container Protected Item.",
"owner": "Azure/module-maintainers"
},
"parameters": {
"name": {
Expand Down Expand Up @@ -201,9 +207,6 @@
},
"protectedItemType": {
"type": "string",
"metadata": {
"description": "Required. The backup item type."
},
"allowedValues": [
"AzureFileShareProtectedItem",
"AzureVmWorkloadSAPAseDatabase",
Expand All @@ -215,7 +218,10 @@
"Microsoft.ClassicCompute/virtualMachines",
"Microsoft.Compute/virtualMachines",
"Microsoft.Sql/servers/databases"
]
],
"metadata": {
"description": "Required. The backup item type."
}
},
"policyId": {
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Recovery Service Vaults Protection Container Protected Item `[Microsoft.RecoveryServices/vaults/protectionContainers/protectedItems]`
# Recovery Service Vaults Protection Container Protected Item `[Microsoft.RecoveryServices/vaults/backupFabrics/protectionContainers/protectedItems]`

This module deploys a Recovery Services Vault Protection Container Protected Item.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.19.5.34762",
"templateHash": "9148923827539718769"
}
"version": "0.20.4.51522",
"templateHash": "6407898441503460857"
},
"name": "Recovery Service Vaults Protection Container Protected Item",
"description": "This module deploys a Recovery Services Vault Protection Container Protected Item.",
"owner": "Azure/module-maintainers"
},
"parameters": {
"name": {
Expand Down Expand Up @@ -36,9 +39,6 @@
},
"protectedItemType": {
"type": "string",
"metadata": {
"description": "Required. The backup item type."
},
"allowedValues": [
"AzureFileShareProtectedItem",
"AzureVmWorkloadSAPAseDatabase",
Expand All @@ -50,7 +50,10 @@
"Microsoft.ClassicCompute/virtualMachines",
"Microsoft.Compute/virtualMachines",
"Microsoft.Sql/servers/databases"
]
],
"metadata": {
"description": "Required. The backup item type."
}
},
"policyId": {
"type": "string",
Expand Down
9 changes: 6 additions & 3 deletions modules/recovery-services/vaults/backup-policies/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.19.5.34762",
"templateHash": "14146696958097265093"
}
"version": "0.20.4.51522",
"templateHash": "13635254612288594433"
},
"name": "Recovery Services Vault Backup Policies",
"description": "This module deploys a Recovery Services Vault Backup Policy.",
"owner": "Azure/module-maintainers"
},
"parameters": {
"recoveryVaultName": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,12 @@
"metadata": {
"_generator": {
"name": "bicep",
"version": "0.19.5.34762",
"templateHash": "3601298674160149217"
}
"version": "0.20.4.51522",
"templateHash": "5682567943042044037"
},
"name": "Recovery Services Vault Backup Storage Config",
"description": "This module deploys a Recovery Service Vault Backup Storage Configuration.",
"owner": "Azure/module-maintainers"
},
"parameters": {
"recoveryVaultName": {
Expand Down
2 changes: 1 addition & 1 deletion modules/recovery-services/vaults/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ module rsv_backupStorageConfiguration 'backup-storage-config/main.bicep' = if (!
}
}

module rsv_protectionContainers 'protection-containers/main.bicep' = [for (protectionContainer, index) in protectionContainers: {
module rsv_backupFabricsProtectionContainers 'backup-fabrics/protection-containers/main.bicep' = [for (protectionContainer, index) in protectionContainers: {
eriqua marked this conversation as resolved.
Show resolved Hide resolved
name: '${uniqueString(deployment().name, location)}-RSV-ProtectionContainers-${index}'
params: {
recoveryVaultName: rsv.name
Expand Down
Loading
Loading