Support handling threads by OkHttp #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this make it so threads:connections is no longer a 1:1 ratio? |
|
It's still 1:1 - limiting number of connections indirectly through thread pool size. The PR is to allow using that thread pool in OkHttpClient. Currently the threading is done by RxJava schedulers but people who are doing large-scale sync or simple parallel async can benefit from a hands-off management of threading. |
|
OkHttp is always blocking IO in that matter. |
jianghaolu
added a commit
to jianghaolu/azure-libraries-for-java
that referenced
this pull request
Jul 25, 2018
jianghaolu
added a commit
to Azure/azure-libraries-for-java
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.