Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for deprecation #1235

Open
chamons opened this issue May 12, 2021 · 4 comments
Open

Support for deprecation #1235

chamons opened this issue May 12, 2021 · 4 comments
Labels
feature-request This issue requires a new behavior in the product in order be resolved. v3 Version 3 of AutoRest C# generator.

Comments

@chamons
Copy link
Contributor

chamons commented May 12, 2021

Describe the issue or request
m4 added support for deprecation in Azure/autorest#4033

It is not clear exactly how we should bubble that up? Maybe use an attribute?
@chamons chamons added the v3 Version 3 of AutoRest C# generator. label May 12, 2021
@pakrym
Copy link
Contributor

pakrym commented May 12, 2021

ObosoleteAttribute might be one option but adding it is considered a breaking change.

@chamons
Copy link
Contributor Author

chamons commented May 13, 2021

In that case, how do we ever support this?

@pakrym
Copy link
Contributor

pakrym commented May 13, 2021

BCL seemed to have started to use the ObsoleteAttribute dotnet/runtime#46767

We need to talk to them about the new thinking about this introducing breaking changes but in general this should be something we design for all libraries not just generated code.

@chamons chamons added the feature-request This issue requires a new behavior in the product in order be resolved. label May 27, 2021
@chamons
Copy link
Contributor Author

chamons commented Jun 2, 2021 •
edited
Loading

3 estimate assumed this is designed from C# side already.

This can not be done until that design is completed (and likely need a use case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request This issue requires a new behavior in the product in order be resolved. v3 Version 3 of AutoRest C# generator.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pakrym @chamons