Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developers should be guided away from more obsolete APIs in .NET 6 #46767

Closed
14 tasks done
jeffhandley opened this issue Jan 8, 2021 · 2 comments
Closed
14 tasks done
Assignees
Labels
area-Meta Bottom Up Work Not part of a theme, epic, or user story Cost:L Work that requires one engineer up to 4 weeks Priority:2 Work that is important, but not critical for the release User Story A single user-facing feature. Can be grouped under an epic.
Milestone

Comments

@jeffhandley
Copy link
Member

jeffhandley commented Jan 8, 2021

With #39269, we marked many APIs as [Obsolete] in .NET 5. Some follow-up infrastructure work was identified during and after that PR, and some other obsoletions have been proposed. With this story, we will:

  1. Complete that follow-up infrastructure work
  2. Consider additional APIs that could be marked as [Obsolete] (optionally with custom diagnostic Ids)
  3. Document those obsoletions
  4. Consider if there are places where a Roslyn Code Fixer should be provided for obsolete APIs

.NET 6 Work Items

Moved to Future

Definition of Done

Each obsoletion needs to have the following Definition of Done applied.

  • Pre-announce the upcoming breaking change to partner teams using our breaking change DL at least 2 weeks before merge
  • Use the Obsoletions.cs file to define the message and diagnostic ID
  • Add the obsoletion to the list of diagnostics
  • Announce the breaking change to our partner teams using our breaking change DL upon merge
  • Create the breaking change document issue
  • Register the aka.ms link for SYSLIBxxxx obsoletions (see @jeffhandley)
@jeffhandley jeffhandley added area-Meta User Story A single user-facing feature. Can be grouped under an epic. Bottom Up Work Not part of a theme, epic, or user story labels Jan 8, 2021
@jeffhandley jeffhandley added this to the 6.0.0 milestone Jan 8, 2021
@jeffhandley jeffhandley self-assigned this Jan 8, 2021
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 8, 2021
@jeffhandley jeffhandley removed the untriaged New issue has not been triaged by the area owner label Jan 8, 2021
@jeffhandley
Copy link
Member Author

/cc @terrajobst @stephentoub @jkotas @GrabYourPitchforks in case any of you has other items you'd like to add to this list.

@jeffhandley
Copy link
Member Author

Closing this issue for .NET 6 as we have completed the obsoletions for that release. #57207 was filed for obsoletions to consider in .NET 7.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Meta Bottom Up Work Not part of a theme, epic, or user story Cost:L Work that requires one engineer up to 4 weeks Priority:2 Work that is important, but not critical for the release User Story A single user-facing feature. Can be grouped under an epic.
Projects
No open projects
Development

No branches or pull requests

4 participants