Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify obsoletion impact of 32-bit Process properties #47137

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

danmoseley
Copy link
Member

  1. Remove double spacing between sentences.
  2. While I was at it, clarify reason for deprecation, which had surprised me.

Addresses #46901

@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jan 18, 2021

Tagging subscribers to this area: @eiriktsarpalis
See info in area-owners.md if you want to be subscribed.

Issue Details
  1. Remove double spacing between sentences.
  2. While I was at it, clarify reason for deprecation, which had surprised me.

Addresses #46901

Author: danmosemsft
Assignees: -
Labels:

area-System.Diagnostics.Process, new-api-needs-documentation

Milestone: -

@danmoseley
Copy link
Member Author

danmoseley commented Jan 18, 2021

@jeffhandley we have 114 obsoletion attributes in this repo that link to https://go.microsoft.com/fwlink/?linkid=14202 which is of limited if any relevance to .NET Core. (Same for its sibling topics). Eg it recommends appname.exe.config. I wonder whether we should either remove the links, or generalize the topics. The details of what is obsoleted and why are linked to from there but (a) it doesn't include newer obsoletions and (b) seems to add nothing over the attributes. Just mentioning in case this connects with the other obsoletion work you think about.

@stephentoub stephentoub changed the title Clarify obsoletion impact Clarify obsoletion impact of 32-bit Process properties Jan 19, 2021
@ghost
Copy link

ghost commented Jan 19, 2021

Hello @danmosemsft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@danmoseley
Copy link
Member Author

I thought github's own automerge feature was enabled on this repo now, but I don't see it above..

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @danmosemsft!

@stephentoub stephentoub merged commit f685ce5 into dotnet:master Jan 19, 2021
@danmoseley danmoseley deleted the clarify.obsolete branch January 19, 2021 17:08
@jeffhandley
Copy link
Member

@danmosemsft 'Developers are directed to helpful documentation for existing obsoletions' (#47255) is now filed and added to 'Developers should be guided away from more obsolete APIs in .NET 6' (#46767).

@ghost ghost locked as resolved and limited conversation to collaborators Feb 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants