LROs do not send the Accept request header
#2765
Labels
CodeGen
Issues that relate to code generation
Comments
heaths
added a commit
to AlexanderSher/azure-sdk-for-net
that referenced
this issue
Oct 13, 2022
Now that we're fixing Azure/autorest.csharp#2726 I can remove the workarounds. Also, some tests were only recorded because we have never sent the `Accept` request header in LROs, which the explicit method calls generated on the client did. That's tracked in Azure/autorest.csharp#2765
heaths
added a commit
to Azure/azure-sdk-for-net
that referenced
this issue
Oct 13, 2022
* Update autorest.csharp to 3.0.0-beta.20221012.1 * Remove workarounds for Question Answering Now that we're fixing Azure/autorest.csharp#2726 I can remove the workarounds. Also, some tests were only recorded because we have never sent the `Accept` request header in LROs, which the explicit method calls generated on the client did. That's tracked in Azure/autorest.csharp#2765 Co-authored-by: Heath Stewart <heaths@microsoft.com>
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this issue
Dec 7, 2022
* Update autorest.csharp to 3.0.0-beta.20221012.1 * Remove workarounds for Question Answering Now that we're fixing Azure/autorest.csharp#2726 I can remove the workarounds. Also, some tests were only recorded because we have never sent the `Accept` request header in LROs, which the explicit method calls generated on the client did. That's tracked in Azure/autorest.csharp#2765 Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the course of resolving #2726 we found that LROs are not - and seemingly never have - sent the
Acceptheader. While this doesn't appear to practically cause any problem, it seems that we should to be technically correct. That said, we will have to re-record a lot of sessions./cc @AlexanderSher @KrzysztofCwalina @tg-msft
The text was updated successfully, but these errors were encountered: