consolidate union types from TCGC #4800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4785
Description
This PR consolidates the shape of our InputUnionType with the shape of
SdkUnionType
in TCGCAn exception is that in TCGC, the
SdkUnionType
hasvalues
to represent the sibling types, which does not really make sense (see this issue), therefore here we name it asVariantTypes
.And when TCGC decides to change it or not to change it, we could align when it happens.
Checklist
To ensure a quick review and merge, please ensure:
Ready to Land?