Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consolidate InputListType and InputDictionaryType with TCGC #4803

Merged
merged 15 commits into from
Jun 25, 2024
Merged

consolidate InputListType and InputDictionaryType with TCGC #4803

merged 15 commits into from
Jun 25, 2024

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Jun 7, 2024 •
edited
Loading

Fixes #4789

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang marked this pull request as ready for review June 7, 2024 08:17
@azure-sdk azure-sdk mentioned this pull request Jun 7, 2024
Closed
@azure-sdk azure-sdk mentioned this pull request Jun 25, 2024
Closed
@ArcturusZhang ArcturusZhang merged commit 25dabbd into Azure:feature/v3 Jun 25, 2024
8 checks passed
@ArcturusZhang ArcturusZhang deleted the consolidate-arraydict-type branch June 25, 2024 14:05
@ArcturusZhang ArcturusZhang mentioned this pull request Jun 25, 2024
Merged
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jun 26, 2024
@ArcturusZhang
sync changes of consolidating TCGC's Array and Dictionary type (#3658)
0af2c98 
Sync up changes from this PR:
Azure/autorest.csharp#4803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archerzz archerzz archerzz approved these changes

@chunyu3 chunyu3 chunyu3 approved these changes

@m-nash m-nash Awaiting requested review from m-nash

@lirenhe lirenhe Awaiting requested review from lirenhe

@ArthurMa1978 ArthurMa1978 Awaiting requested review from ArthurMa1978

@hallipr hallipr Awaiting requested review from hallipr

@JoshLove-msft JoshLove-msft Awaiting requested review from JoshLove-msft

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate InputListType and InputDictionaryType with TCGC's SdkArrayType and SdkDictionaryType
3 participants
@ArcturusZhang @archerzz @chunyu3