generate assemblyinfo.cs for new module #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dolauli
requested changes
Sep 13, 2024
| public class NewAssemblyInfo : PSCmdlet | ||
| { | ||
| private readonly string assemblyInfoPath = Path.Combine("${$project.baseFolder}", "Properties", "AssemblyInfo.cs"); | ||
| private const string assemblyName = "${$project.title}"; |
There was a problem hiding this comment.
Please use $(module-name) instead of title here.
There was a problem hiding this comment.
module-name is Az.xxx, title is without Az, I want it to be without 'Az'
| @@ -340,6 +346,11 @@ export class Project extends codeDomProject { | |||
| const afterBuildTasksArgsDictionary: Dictionary<string> = await this.state.getValue<Dictionary<string>>('after-build-tasks-args', {}); | |||
| this.afterBuildTasksArgs = JSON.stringify(afterBuildTasksArgsDictionary); | |||
|
|
|||
| this.assemblyInfoFolder = await this.state.getValue('assemblyInfo-folder', ''); | |||
There was a problem hiding this comment.
How about just hardcode the assemblyInfoFolder to Properties
| @@ -166,11 +166,17 @@ if (Test-Path (Join-Path $PSScriptRoot 'generate-portal-ux.ps1')) | |||
| . (Join-Path $PSScriptRoot 'generate-portal-ux.ps1') | |||
| } | |||
|
|
|||
| $assemblyInfoPath = Join-Path $PSScriptRoot 'Properties' 'AssemblyInfo.cs' | |||
There was a problem hiding this comment.
I think we only have it for Azure.
| # ---------------------------------------------------------------------------------- | ||
| "); | ||
| sb.Append($"{Environment.NewLine}"); | ||
| sb.AppendLine("using System;"); |
There was a problem hiding this comment.
We could consider hardcode all the stuff except for assemblyName, Guid, and assemblyVersion.
dolauli
approved these changes
Sep 19, 2024
dolauli
added a commit
that referenced
this pull request
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.