Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add back stream response reading for paging #2656

Closed
iscai-msft opened this issue Jun 24, 2024 · 0 comments · Fixed by #2658
Closed

add back stream response reading for paging #2656

iscai-msft opened this issue Jun 24, 2024 · 0 comments · Fixed by #2658
Assignees
@iscai-msft
Labels
blocking service bug This issue requires a change to an existing behavior in the product in order to be resolved. p0

Comments

@iscai-msft
Copy link
Contributor

iscai-msft commented Jun 24, 2024 •
edited
Loading

When we converted completely over to the new requests and responses in azure.core.rest (pr here), we accidentally got rid of streamed paging response reading (see example here). Add back logic for this.

cc @kristapratico
@iscai-msft iscai-msft added bug This issue requires a change to an existing behavior in the product in order to be resolved. p0 blocking service labels Jun 24, 2024
@iscai-msft iscai-msft self-assigned this Jun 24, 2024
@iscai-msft iscai-msft mentioned this issue Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iscai-msft iscai-msft

Labels
blocking service bug This issue requires a change to an existing behavior in the product in order to be resolved. p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add back response.read() check for all operations Azure/autorest.python
1 participant
@iscai-msft