strict sphinx purview-workflow #36118
Conversation
|
API change check API changes are not detected in this pull request. |
| ) | ||
| response = pipeline_response.http_response | ||
|
|
||
| if response.status_code not in [200]: | ||
| if _stream: | ||
| await response.read() # Load the body in memory and close the socket |
There was a problem hiding this comment.
Is this now happening somewhere else?
There was a problem hiding this comment.
@iscai-msft do you know the reason for the change in the generated operations here?
There was a problem hiding this comment.
hmm that's interesting, let me take a look at this. We had removed this logic for stream-only operations, but I think this got overshot. Let me work on this today
There was a problem hiding this comment.
@annatisch @kristapratico @iscai-msft It is expected since _stream is always "False" therefore no need to judge it:
Context:
The logic is introduced in Azure/autorest.python#2628 and ever discussed here: Azure/autorest.python#2589 (comment) and Azure/autorest.python#2589 (comment)
There was a problem hiding this comment.
forgot to respond in this issue, but I believe this issue got resolved, is that correct @kristapratico?
|
Hi @kristapratico. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @kristapratico. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
Resolves #33592