Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mgmt] serialization error when setting model property with azure.core.serialization.NULL #2607

Merged
merged 3 commits into from
May 31, 2024

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented May 31, 2024

fixes #2606

for none_value, json_string in test_cases:
for item in [self.TestObj2(attr=none_value), {"properties": {"Attr": none_value}}]:
json_body = self.s.body(item, "TestObj2")
assert json.dumps(json_body) == json_string
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case for code change

@msyyc msyyc enabled auto-merge May 31, 2024 06:46
@msyyc msyyc disabled auto-merge May 31, 2024 06:46
@msyyc msyyc enabled auto-merge May 31, 2024 07:43
@msyyc msyyc added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 31, 2024
@msyyc msyyc added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 31, 2024
@msyyc msyyc added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 31, 2024
@iscai-msft iscai-msft added this pull request to the merge queue May 31, 2024
@iscai-msft iscai-msft removed this pull request from the merge queue due to a manual request May 31, 2024
@iscai-msft iscai-msft merged commit 8a37852 into main May 31, 2024
15 checks passed
@iscai-msft iscai-msft deleted the fix-serialization-error branch May 31, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Mgmt] serialization error when setting model property with azure.core.serialization.NULL
2 participants