Re-enable the rpc cases & Bump compiler to v0.55 (#1881)

* Re-enable the rpc cases * Bump the compiler version * Regen int and smoke testing * Update the code * Remove the useless one
Azure · Jun 7, 2023 · e1e40a5 · e1e40a5
1 parent 9c63f8a
commit e1e40a5
Show file tree

Hide file tree

Showing 26 changed files with 862 additions and 592 deletions.
diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml
diff --git a/packages/autorest.typescript/test/integration/generated/lro/src/operations/lROs.ts b/packages/autorest.typescript/test/integration/generated/lro/src/operations/lROs.ts
@@ -365,8 +365,7 @@ export class LROsImpl implements LROs {
       OperationState<LROsPatch201RetryWithAsyncHeaderResponse>
     >(lro, {
       restoreFrom: options?.resumeFrom,
-      intervalInMs: options?.updateIntervalInMs,
-      resourceLocationConfig: "azure-async-operation"
+      intervalInMs: options?.updateIntervalInMs
     });
     await poller.poll();
     return poller;

diff --git a/packages/typespec-test/package.json b/packages/typespec-test/package.json
@@ -3,17 +3,17 @@
   "version": "1.0.0",
   "type": "module",
   "dependencies": {
-    "@typespec/compiler": "~0.44.0",
+    "@typespec/compiler": ">=0.45.0 <1.0.0",
     "@azure-tools/typespec-ts": "workspace:^0.13.1",
-    "@typespec/http": "~0.44.0",
-    "@typespec/rest": "~0.44.0",
-    "@typespec/openapi": "~0.44.0",
-    "@typespec/versioning": "~0.44.0",
-    "@azure-tools/typespec-azure-core": "~0.30.0",
-    "@azure-tools/typespec-autorest": "~0.30.0",
-    "@azure-tools/typespec-client-generator-core": "~0.30.0",
-    "@typespec/openapi3": "~0.44.0",
-    "@typespec/prettier-plugin-typespec": "~0.44.0",
+    "@typespec/http": ">=0.45.0 <1.0.0",
+    "@typespec/rest": ">=0.45.0 <1.0.0",
+    "@typespec/openapi": ">=0.45.0 <1.0.0",
+    "@typespec/versioning": ">=0.45.0 <1.0.0",
+    "@azure-tools/typespec-azure-core": ">=0.31.0 <1.0.0",
+    "@azure-tools/typespec-autorest": ">=0.31.0 <1.0.0",
+    "@azure-tools/typespec-client-generator-core": ">=0.31.0 <1.0.0",
+    "@typespec/openapi3": ">=0.45.0 <1.0.0",
+    "@typespec/prettier-plugin-typespec": ">=0.45.0 <1.0.0",
     "prettier": "2.7.1"
   },
   "devDependencies": {

diff --git a/packages/typespec-test/test/anomalyDetector/generated/openapi/v1.1/openapi.json b/packages/typespec-test/test/anomalyDetector/generated/openapi/v1.1/openapi.json
diff --git a/packages/typespec-test/test/authoring/generated/openapi/openapi.json b/packages/typespec-test/test/authoring/generated/openapi/openapi.json
@@ -66,8 +66,8 @@
                     "$ref": "#/definitions/Project"
                   },
                   "x-ms-identifiers": [],
-                  "x-typespec-name": "Project[]",
-                  "description": "The Project items on this page"
+                  "description": "The Project items on this page",
+                  "x-typespec-name": "Project[]"
                 },
                 "nextLink": {
                   "type": "string",
@@ -131,7 +131,7 @@
             "description": "The request has succeeded.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -144,7 +144,7 @@
             "description": "The request has succeeded and a new resource has been created as a result.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -226,7 +226,7 @@
             "description": "The request has been accepted for processing, but processing has not yet completed.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -294,7 +294,7 @@
             "description": "The request has been accepted for processing, but processing has not yet completed.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -336,7 +336,7 @@
             "description": "The request has been accepted for processing, but processing has not yet completed.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -387,7 +387,7 @@
             "description": "The request has been accepted for processing, but processing has not yet completed.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -436,8 +436,8 @@
                     "$ref": "#/definitions/Deployment"
                   },
                   "x-ms-identifiers": [],
-                  "x-typespec-name": "Deployment[]",
-                  "description": "The Deployment items on this page"
+                  "description": "The Deployment items on this page",
+                  "x-typespec-name": "Deployment[]"
                 },
                 "nextLink": {
                   "type": "string",
@@ -551,7 +551,7 @@
             "description": "The request has succeeded.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -564,7 +564,7 @@
             "description": "The request has succeeded and a new resource has been created as a result.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -614,7 +614,7 @@
             "description": "The request has been accepted for processing, but processing has not yet completed.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -786,7 +786,7 @@
             "description": "The request has been accepted for processing, but processing has not yet completed.",
             "headers": {
               "Operation-Location": {
-                "description": "The location of an instance of OperationStatus",
+                "description": "The location for monitoring the operation state.",
                 "type": "string",
                 "format": "uri"
               }
@@ -916,8 +916,8 @@
             "$ref": "#/definitions/Azure.Core.Foundations.Error"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "Azure.Core.Foundations.Error[]",
-          "description": "An array of details about specific errors that led to this reported error."
+          "description": "An array of details about specific errors that led to this reported error.",
+          "x-typespec-name": "Azure.Core.Foundations.Error[]"
         },
         "innererror": {
           "$ref": "#/definitions/Azure.Core.Foundations.InnerError",
@@ -927,8 +927,7 @@
       "description": "The error object.",
       "required": [
         "code",
-        "message",
-        "details"
+        "message"
       ]
     },
     "Azure.Core.Foundations.ErrorResponse": {
@@ -956,13 +955,11 @@
           "description": "Inner error."
         }
       },
-      "description": "An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses.",
-      "required": [
-        "code"
-      ]
+      "description": "An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses."
     },
     "Azure.Core.Foundations.OperationState": {
       "type": "string",
+      "description": "Enum describing allowed operation states.",
       "enum": [
         "InProgress",
         "Succeeded",
@@ -971,7 +968,29 @@
       ],
       "x-ms-enum": {
         "name": "OperationState",
-        "modelAsString": true
+        "modelAsString": true,
+        "values": [
+          {
+            "name": "InProgress",
+            "value": "InProgress",
+            "description": "The operation is in progress."
+          },
+          {
+            "name": "Succeeded",
+            "value": "Succeeded",
+            "description": "The operation has completed successfully."
+          },
+          {
+            "name": "Failed",
+            "value": "Failed",
+            "description": "The operation has failed."
+          },
+          {
+            "name": "Canceled",
+            "value": "Canceled",
+            "description": "The operation has been canceled by the user."
+          }
+        ]
       }
     },
     "Deployment": {
@@ -1023,8 +1042,8 @@
             "$ref": "#/definitions/JobWarning"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "JobWarning[]",
-          "description": "The warnings that were encountered while executing the job."
+          "description": "The warnings that were encountered while executing the job.",
+          "x-typespec-name": "JobWarning[]"
         },
         "errors": {
           "$ref": "#/definitions/Azure.Core.Foundations.Error",
@@ -1092,8 +1111,8 @@
             "$ref": "#/definitions/JobWarning"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "JobWarning[]",
-          "description": "The warnings that were encountered while executing the job."
+          "description": "The warnings that were encountered while executing the job.",
+          "x-typespec-name": "JobWarning[]"
         },
         "errors": {
           "$ref": "#/definitions/Azure.Core.Foundations.Error",
@@ -1155,8 +1174,8 @@
             "$ref": "#/definitions/SupportedLanguage"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "SupportedLanguage[]",
-          "description": "The SupportedLanguage items on this page"
+          "description": "The SupportedLanguage items on this page",
+          "x-typespec-name": "SupportedLanguage[]"
         },
         "nextLink": {
           "type": "string",
@@ -1179,8 +1198,8 @@
             "$ref": "#/definitions/TrainingConfigVersion"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "TrainingConfigVersion[]",
-          "description": "The TrainingConfigVersion items on this page"
+          "description": "The TrainingConfigVersion items on this page",
+          "x-typespec-name": "TrainingConfigVersion[]"
         },
         "nextLink": {
           "type": "string",
@@ -1383,8 +1402,8 @@
             "$ref": "#/definitions/JobWarning"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "JobWarning[]",
-          "description": "The warnings that were encountered while executing the job."
+          "description": "The warnings that were encountered while executing the job.",
+          "x-typespec-name": "JobWarning[]"
         },
         "errors": {
           "$ref": "#/definitions/Azure.Core.Foundations.Error",
@@ -1466,8 +1485,8 @@
       "required": true,
       "description": "The API version to use for this operation.",
       "x-ms-client-name": "apiVersion",
-      "minLength": 1,
       "type": "string",
+      "minLength": 1,
       "x-ms-parameter-location": "method"
     },
     "Azure.Core.MaxPageSizeQueryParameter": {

diff --git a/packages/typespec-test/test/confidentialLedger/generated/openapi/openapi.json b/packages/typespec-test/test/confidentialLedger/generated/openapi/openapi.json
@@ -422,8 +422,8 @@
             "in": "path",
             "required": true,
             "description": "The user id, either an AAD object ID or certificate fingerprint.",
-            "x-ms-skip-url-encoding": true,
-            "type": "string"
+            "type": "string",
+            "x-ms-skip-url-encoding": true
           }
         ],
         "responses": {
@@ -457,8 +457,8 @@
             "in": "path",
             "required": true,
             "description": "The user id, either an AAD object ID or certificate fingerprint.",
-            "x-ms-skip-url-encoding": true,
-            "type": "string"
+            "type": "string",
+            "x-ms-skip-url-encoding": true
           }
         ],
         "responses": {
@@ -495,8 +495,8 @@
             "in": "path",
             "required": true,
             "description": "The user id, either an AAD object ID or certificate fingerprint.",
-            "x-ms-skip-url-encoding": true,
-            "type": "string"
+            "type": "string",
+            "x-ms-skip-url-encoding": true
           },
           {
             "name": "resource",
@@ -562,8 +562,8 @@
             "$ref": "#/definitions/Azure.Core.Foundations.Error"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "Azure.Core.Foundations.Error[]",
-          "description": "An array of details about specific errors that led to this reported error."
+          "description": "An array of details about specific errors that led to this reported error.",
+          "x-typespec-name": "Azure.Core.Foundations.Error[]"
         },
         "innererror": {
           "$ref": "#/definitions/Azure.Core.Foundations.InnerError",
@@ -573,8 +573,7 @@
       "description": "The error object.",
       "required": [
         "code",
-        "message",
-        "details"
+        "message"
       ]
     },
     "Azure.Core.Foundations.ErrorResponse": {
@@ -602,10 +601,7 @@
           "description": "Inner error."
         }
       },
-      "description": "An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses.",
-      "required": [
-        "code"
-      ]
+      "description": "An object containing more specific information about the error. As per Microsoft One API guidelines - https://github.com/Microsoft/api-guidelines/blob/vNext/Guidelines.md#7102-error-condition-responses."
     },
     "Collection": {
       "type": "object",
@@ -755,8 +751,8 @@
             "$ref": "#/definitions/LedgerEntry"
           },
           "x-ms-identifiers": [],
-          "x-typespec-name": "LedgerEntry[]",
-          "description": "Array of ledger entries."
+          "description": "Array of ledger entries.",
+          "x-typespec-name": "LedgerEntry[]"
         },
         "state": {
           "$ref": "#/definitions/LedgerQueryState",
@@ -845,8 +841,8 @@
       "required": true,
       "description": "The API version to use for this operation.",
       "x-ms-client-name": "apiVersion",
-      "minLength": 1,
       "type": "string",
+      "minLength": 1,
       "x-ms-parameter-location": "method"
     },
     "CollectionIdParameter": {

diff --git a/...pespec-test/test/confidentialLedger/generated/typespec-ts/src/confidentialLedgerClient.ts b/...pespec-test/test/confidentialLedger/generated/typespec-ts/src/confidentialLedgerClient.ts
@@ -8,7 +8,7 @@ import { ConfidentialLedgerClient } from "./clientDefinitions";
 
 /**
  * Initialize a new instance of `ConfidentialLedgerClient`
- * @param ledgerUri - The parameter ledgerUri
+ * @param ledgerUri - Represent a URL string as described by https://url.spec.whatwg.org/
  * @param credentials - uniquely identify client credential
  * @param options - the parameter for all optional parameters
  */