Issues #3: CADL Generated Code Issue in EventGrid SDK #1820
Comments
|
I think this is by design, we support both commonjs and es modules. @joheredi Could you help confirm ? Thanks |
|
We need to keep |
Merged
3 tasks
sarangan12
added a commit
to Azure/azure-sdk-for-js
that referenced
this issue
May 22, 2023
) ### Packages impacted by this PR @Azure/eventgrid ### Issues associated with this PR NA ### Describe the problem that is addressed by this PR 1. The EventGrid Service team has introduced a new Client called `EventGridClient` with 4 apis - `publishCloudEvent`, `publishCloudEvents`, `receiveCloudEvents`, `acknowledgeCloudEvents`, `releaseCloudEvents` and `rejectCloudEvents`. Now, the service is represented using the [new CADL specification](https://github.com/Azure/azure-rest-api-specs/tree/feature/eventgrid/typespec/specification/eventgrid/Azure.Messaging.EventGrid). This SDK, in this PR, has been generated using the new [JS SDK CADL Generator](https://github.com/Azure/autorest.typescript/tree/main/packages/typespec-ts). 2. During the generation process, I had a few issues in the generation process. Seperate issues have been filed for the same and many of them have already been resolved. For the remaining issues, I have provided manual patches in this PR, so the release schedule will not be impacted. Jose is already working on fixing any remaining issues. A complete list of issues can be found in the related PRs/Issues section below. 3. This is a **beta** release. So, this code is not merged to the main branch. The code changes are merged to a private branch **feature/eventgrid/4_13_beta_1**. **APIView To Approve** https://apiview.dev/Assemblies/Review/de09872b51a24f489981db711a73c430/2e0e731c80a840faab6df4c51acb6e95?diffRevisionId=2a4fb5a9265847c09428acb9b0581b0e&doc=False&diffOnly=True ### What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen? No special design considerations for the generation process. ### Are there test cases added in this PR? _(If not, why?)_ This version of the eventgrid service has not been released to public and not available through azure portal. So, the test cases are not added to this PR for now. Locally, I have tested the code changes with private test resources and confirmed that the apis are working fine. ### Provide a list of related PRs/Issues _(if any)_ 1. Azure/autorest.typescript#1818 2. Azure/autorest.typescript#1819 3. Azure/autorest.typescript#1820 4. Azure/autorest.typescript#1821 5. Azure/autorest.typescript#1851 6. Azure/autorest.typescript#1852 7. Azure/autorest.typescript#1853 ### Command used to generate this PR:**_(Applicable only to SDK release request PRs)_ npx tsp compile main.tsp ### Checklists - [X] Added impacted package name to the issue description - [ ] Does this PR needs any fixes in the SDK Generator?** _(If so, create an Issue in the [Autorest/typescript](https://github.com/Azure/autorest.typescript) repository and link it here)_ - [X] Added a changelog (if necessary) @joheredi @ellismg Please review and approve the PR. @xirzec FYI....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on the EventGrid SDK, generated from the CADL files, I have noticed the following. In several places such as
src/AzureMessagingEventGrid.tsfile we have imports such asimport { ClientOptions } from "./common/interfaces.js";. The.jsreferences must be removed.@joheredi @xirzec FYI....
The text was updated successfully, but these errors were encountered: