Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional body #2114

Closed
zzhxiaofeng opened this issue Nov 14, 2023 · 2 comments
Closed

Support optional body #2114

zzhxiaofeng opened this issue Nov 14, 2023 · 2 comments
Assignees
@MaryGao
Labels
HRLC test-coverage

Comments

@zzhxiaofeng
Copy link
Contributor

Issue description:
There is an error in the code generated for body optionality. the generated optional body can not be undefined. The detailed error code is shown as following:
image
image

@MaryGao for notification.
@zzhxiaofeng zzhxiaofeng changed the title Add test cases for body optionality parameter support optional body Nov 14, 2023
@zzhxiaofeng zzhxiaofeng changed the title support optional body Support optional body Nov 14, 2023
@MaryGao MaryGao self-assigned this Nov 14, 2023
@zzhxiaofeng zzhxiaofeng mentioned this issue Nov 14, 2023
Closed
@MaryGao MaryGao mentioned this issue Nov 16, 2023
Merged
@qiaozha
Copy link
Member

qiaozha commented Dec 6, 2023

please help check what would happen if there's required properties in optional body parameter. Thanks

@qiaozha qiaozha mentioned this issue Jan 17, 2024
Closed
@MaryGao
Copy link
Member

MaryGao commented Jan 24, 2024

closed as duplicated with #2208

@MaryGao MaryGao closed this as completed Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaryGao MaryGao

Labels
HRLC test-coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add modular coverage cases for body-optionality in cadl-ranch zzhxiaofeng/autorest.typescript
3 participants
@MaryGao @zzhxiaofeng @qiaozha