Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the empty default value issue for array in body model #2111

Merged
merged 9 commits into from
Nov 16, 2023

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Nov 13, 2023

fixes #2108

@MaryGao MaryGao changed the title Update the array items fix Fix the array items in body model Nov 16, 2023
@MaryGao MaryGao marked this pull request as ready for review November 16, 2023 05:31
@MaryGao MaryGao changed the title Fix the array items in body model Fix the default value isue for array items in body model Nov 16, 2023
it("required nullable header would report diagnostic", async () => {
try {
// TODO: need to fix the tests
describe.skip("array as body", () => {
Copy link
Member Author

@MaryGao MaryGao Nov 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optionaly and nullable body check will be in another issue #2114.

@MaryGao MaryGao changed the title Fix the default value isue for array items in body model Fix the empty default value issue for array items in body model Nov 16, 2023
@MaryGao MaryGao changed the title Fix the empty default value issue for array items in body model Fix the empty default value issue for array in body model Nov 16, 2023
@MaryGao MaryGao merged commit b0561b6 into Azure:main Nov 16, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generator defaults to an empty array for optional array properties
2 participants