Dpg code gen fix docs #1861
Merged
Dpg code gen fix docs #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Upgrade the cadl-ranch version * Add test cases for encode * Typo fix * Change to workspace
|
may fix this #1841 |
qiaozha
reviewed
May 25, 2023
| new Set(operation.responses.flatMap((r) => r.statusCodes)).values() | ||
| ); | ||
|
|
||
| statusCodes.push("Default"); |
There was a problem hiding this comment.
Should we consider LogicalResponse here ? @MaryGao
qiaozha
reviewed
May 25, 2023
| export class EventGridClient { | ||
| private _client: EventGridContext; | ||
|
|
||
| /** Azure Messaging EventGrid Client */ | ||
| constructor( | ||
| endpoint: string, | ||
| credential: KeyCredential, | ||
| options: ClientOptions = {} | ||
| options: EventGridClientOptions = {} |
There was a problem hiding this comment.
Just a reminder, may need to check the ClientOptions in the rest level. Also, should we generate EventGridClientOptions if there's no actual difference between EventGridClientOptions and ClientOptions ? For RLC, the answer is no, right now.
There was a problem hiding this comment.
Let's add the logic to remove if no client level parameters in a separate PR
qiaozha
approved these changes
May 26, 2023
…ure#1869) * try fix subscriptionId in tenant level * use overload to fix subscription optional * refine and fix smoke test * fix test and resolve comments * fix sample transform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classical client was missing method names. Adding them, also a couple of other fixes: