-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix union in header query issue #2189
Conversation
Hold this PR as there's some issues in the modular layer. |
skip enum test as not supported yet.
Moving the isKey readOnly logic fix and support named union in Modular layer into this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
export async function get( | ||
context: Client, | ||
testHeader: "A" | "B", | ||
body: string, | ||
options: GetOptions = { requestOptions: {} }, | ||
): Promise<void> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's the typespec
op get(
@header("test-header") testHeader: "A" | "B",
@body body: string,
): { @header("test-header") testHeader: "A" | "B" };
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
create an issue #2202 to track this.
We can fix remaining issue in other PRs. |
fixes #2185