Fix the union credential issue #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
commented
Jan 9, 2024
MaryGao
commented
Jan 9, 2024
|
|
||
| const client = getClient(baseUrl, credentials, options) as LearnClient; | ||
|
|
||
| if (isKeyCredential(credentials)) { |
There was a problem hiding this comment.
The helper is supposed to be added in core-auth. And the core pr is here Azure/azure-sdk-for-js#28191.
MaryGao
changed the title
joheredi
reviewed
Jan 23, 2024
joheredi
approved these changes
Jan 23, 2024
lirenhe
reviewed
Feb 6, 2024
packages/typespec-test/test/mslearn/generated/typespec-ts/.eslintrc.json
Outdated
Show resolved
Hide resolved
lirenhe
approved these changes
Feb 6, 2024
qiaozha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2186