upgrade-typespec-compiler-to-0.51.0 #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaozha
requested review from
sarangan12,
joheredi and
MaryGao
as code owners
qiaozha
changed the title
qiaozha
changed the title
qiaozha
commented
Jan 17, 2024
packages/typespec-ts/test/integration/generated/mediaTypes/src/clientDefinitions.ts
Outdated
Show resolved
Hide resolved
.../typespec-ts/test/integration/generated/parameters/body-optionality/src/clientDefinitions.ts
Show resolved
Hide resolved
packages/typespec-ts/test/integration/generated/unions/src/outputModels.ts
Show resolved
Hide resolved
packages/typespec-ts/test/modularIntegration/clientStructureDefault.spec.ts
Show resolved
Hide resolved
...odularIntegration/generated/client/structure/renamed-operation/src/RenamedOperationClient.ts
Outdated
Show resolved
Hide resolved
packages/typespec-ts/test/modularIntegration/generated/parameters/spread/src/models/options.ts
Outdated
Show resolved
Hide resolved
joheredi
approved these changes
Jan 17, 2024
lirenhe
reviewed
Jan 18, 2024
packages/typespec-test/test/openai_generic/generated/typespec-ts/src/index.ts
Show resolved
Hide resolved
lirenhe
approved these changes
Jan 18, 2024
MaryGao
reviewed
Jan 18, 2024
packages/typespec-ts/test/integration/generated/projection/src/clientDefinitions.ts
Show resolved
Hide resolved
MaryGao
reviewed
Jan 18, 2024
MaryGao
reviewed
Jan 18, 2024
MaryGao
approved these changes
Jan 18, 2024
qiaozha
commented
Jan 19, 2024
| @@ -9,7 +9,6 @@ options: | |||
| azureSdkForJs: false | |||
| isTypeSpecTest: true | |||
| isModularLibrary: true | |||
| hierarchyClient: false | |||
There was a problem hiding this comment.
We have to enable the hierarchyClient for client structure related test as tcgc has an issue about indicating whether an interface has an @operationGroup decorator on it. and previously, we still respect the @operationGroup decorator even if the hierarchyClient is false and enableOperationGroup is not enabled.
qiaozha
commented
Jan 19, 2024
| @@ -7,4 +7,3 @@ export { | |||
| RenamedOperationClientOptions, | |||
| ServiceContext, | |||
| } from "./RenamedOperationContext.js"; | |||
| export { renamedTwo, renamedFour, renamedSix } from "./group/index.js"; | |||
There was a problem hiding this comment.
this is expected as we require customer to access the operation under ./api/group subpath with hierarchyClient enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.