Client name and encoded name support #2297

qiaozha · 2024-02-19T08:07:45Z

fixes #2259

* add test * update test

…om/qiaozha/autorest.typescript into clientName-and-encodedName-support

packages/typespec-ts/src/modular/buildCodeModel.ts

packages/typespec-ts/src/modular/helpers/operationHelpers.ts

packages/typespec-ts/src/modular/buildCodeModel.ts

packages/typespec-ts/src/utils/modelUtils.ts

packages/typespec-ts/test/integration/arrayItemTypes.spec.ts

qiaozha · 2024-03-03T11:13:40Z

packages/typespec-ts/test/integration/generated/azure/core/src/models.ts

@@ -22,3 +22,6 @@ export interface ListItemInputBody {
  /** The name of the input. */
  inputName: string;
 }
+
+/** Alias for ListItemInputExtensibleEnum */
+export type ListItemInputExtensibleEnum = string | "First" | "Second";


this is because cadl-ranch has changed extensible enum into union, I think we could support it better when we finish the extensible enum review.

packages/typespec-ts/test/integration/clientNaming.spec.ts

packages/typespec-ts/test/modularIntegration/clientNaming.spec.ts

MaryGao

Approved. Overall LGTM. pls ensure the RLC header case is correct. If the modular client name is not supported i prefer not adding cases.

packages/typespec-ts/test/modularIntegration/clientNaming.spec.ts

packages/typespec-ts/test/modularIntegration/generated/client/naming/src/api/operations.ts

I still have concerns for modular cases and could you take a look?

* update modular test case * remove console.log * add assert about the header in the response * update modular test case * Update packages/typespec-ts/test/integration/clientNaming.spec.ts --------- Co-authored-by: Jiao Di (MSFT) <80496810+v-jiaodi@users.noreply.github.com>

MaryGao · 2024-03-05T02:42:01Z

packages/typespec-ts/test/modularIntegration/clientNaming.spec.ts

+  it("should work with header response", async () => {
+    try {
+      const result = await client.response({
+        onResponse: function (res) {


@joheredi I remember you mentioned we should avoid onResponse option in modular? Am I correct?

MaryGao

LGTM for this pr but seems ci failed.

qiaozha · 2024-03-05T07:14:54Z

packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/src/index.ts

-  LoadTestRunClient,
-  LoadTestRunClientOptions,
-} from "./loadTestRun/LoadTestRunClient.js";
+  TestRunOperationsClient,
+  TestRunOperationsClientOptions,


this change is correct as client.tsp defined.

qiaozha · 2024-03-05T07:17:49Z

...-test/test/loadtesting_modular/generated/typespec-ts/src/testRunOperations/api/operations.ts

-    errorDetails: !result.body["errorDetails"]
-      ? result.body["errorDetails"]
-      : result.body["errorDetails"].map((p) => ({ message: p["message"] })),
+    errorDetails:
+      result.body["errorDetails"] === undefined
+        ? result.body["errorDetails"]
+        : result.body["errorDetails"].map((p) => ({ message: p["message"] })),


this is to work around typescript compiler bug of optional chain, see from playground link

qiaozha · 2024-03-05T07:26:27Z

packages/typespec-test/test/batch_modular/generated/typespec-ts/src/models/models.ts

@@ -1532,7 +1532,7 @@ export type DynamicVNetAssignmentScope = string;
 /** The endpoint configuration for a Pool. */
 export interface PoolEndpointConfiguration {
  /** A list of inbound NAT Pools that can be used to address specific ports on an individual Compute Node externally. The maximum number of inbound NAT Pools per Batch Pool is 5. If the maximum number of inbound NAT Pools is exceeded the request fails with HTTP status code 400. This cannot be specified if the IPAddressProvisioningType is NoPublicIPAddresses. */
-  inboundNATPools: InboundNATPool[];
+  inboundNatPools: InboundNATPool[];


this is because there are projectedName client in the typespec.

qiaozha and others added 16 commits February 1, 2024 17:31

clientName-and-encodedName-support

1e04c47

Merge branch 'main' into clientName-and-encodedName-support

b13083f

fix build error

fe7d805

fix format

4dad86c

fix unit test

2c869c6

reserve test work

6f6535c

merge main

bf1aa53

modular fixes

5bb484a

add test

c024c53

update test

0ccd0de

Add test (#13)

d94dc7c

* add test * update test

fix client name in namespace

14439f9

merge main and resolve conflicts

e97f505

update cadl-ranch version

c28a90f

Merge branch 'clientName-and-encodedName-support' of https://github.c…

c62f151

…om/qiaozha/autorest.typescript into clientName-and-encodedName-support

update cadl-ranch version

9453181

qiaozha self-assigned this Feb 28, 2024

qiaozha added 5 commits February 28, 2024 15:11

fix clientoptions

644828e

merge main

458bd2b

fix ut

c5c13dc

use getLibraryName and getWireName

1d73f6b

fix format

a99e28b

qiaozha commented Feb 28, 2024

View reviewed changes

packages/typespec-ts/src/modular/buildCodeModel.ts Outdated Show resolved Hide resolved

packages/typespec-ts/src/modular/buildCodeModel.ts Show resolved Hide resolved

kazrael2119 and others added 7 commits February 29, 2024 11:07

Update clientNaming.spec.ts

55c85b8

fix naming issues

d03c7c3

fix smoke test

5f24c4c

union as enum

754be22

fix discriminator

122aeb3

fix union first variant missing

5f2cae4

add back projection for rlc

b4d72ce

qiaozha added 2 commits March 3, 2024 17:55

update cadl-ranch version

c97c344

add back projection test and fix client naming test

70a5eaa

qiaozha commented Mar 3, 2024

View reviewed changes

qiaozha marked this pull request as ready for review March 3, 2024 11:27

qiaozha requested review from sarangan12, joheredi and MaryGao as code owners March 3, 2024 11:27

MaryGao previously approved these changes Mar 4, 2024

View reviewed changes

MaryGao reviewed Mar 4, 2024

View reviewed changes

packages/typespec-ts/test/modularIntegration/clientNaming.spec.ts Show resolved Hide resolved

MaryGao reviewed Mar 4, 2024

View reviewed changes

packages/typespec-ts/test/modularIntegration/generated/client/naming/src/api/operations.ts Outdated Show resolved Hide resolved

MaryGao reviewed Mar 4, 2024

View reviewed changes

packages/typespec-ts/test/modularIntegration/generated/client/naming/src/api/operations.ts Outdated Show resolved Hide resolved

MaryGao self-requested a review March 4, 2024 06:41

qiaozha and others added 2 commits March 4, 2024 15:54

support client naming in modular

66747fd

lirenhe approved these changes Mar 4, 2024

View reviewed changes

fix parameter rest api name

f15c3b4

MaryGao reviewed Mar 5, 2024

View reviewed changes

MaryGao approved these changes Mar 5, 2024

View reviewed changes

qiaozha added 3 commits March 5, 2024 11:31

temporarily workaround weird typescript compiler bug

42f05d9

apply normalizeName for property name and fix smoke test

d0df7d1

fix cadl ranch

e65060e

qiaozha commented Mar 5, 2024

View reviewed changes

qiaozha added 2 commits March 5, 2024 15:55

fix override name for enum and union

f3cce22

fix ci

ef9073b

joheredi approved these changes Mar 6, 2024

View reviewed changes

qiaozha merged commit f06f22a into Azure:main Mar 6, 2024
28 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Client name and encoded name support #2297

Client name and encoded name support #2297

qiaozha commented Feb 19, 2024 •

edited

Loading

qiaozha Mar 3, 2024

MaryGao left a comment •

edited

Loading

MaryGao Mar 5, 2024

MaryGao left a comment •

edited

Loading

qiaozha Mar 5, 2024

qiaozha Mar 5, 2024

qiaozha Mar 5, 2024

Client name and encoded name support #2297

Client name and encoded name support #2297

Conversation

qiaozha commented Feb 19, 2024 • edited Loading

qiaozha Mar 3, 2024

Choose a reason for hiding this comment

MaryGao left a comment • edited Loading

Choose a reason for hiding this comment

MaryGao Mar 5, 2024

Choose a reason for hiding this comment

MaryGao left a comment • edited Loading

Choose a reason for hiding this comment

qiaozha Mar 5, 2024

Choose a reason for hiding this comment

qiaozha Mar 5, 2024

Choose a reason for hiding this comment

qiaozha Mar 5, 2024

Choose a reason for hiding this comment

qiaozha commented Feb 19, 2024 •

edited

Loading

MaryGao left a comment •

edited

Loading

MaryGao left a comment •

edited

Loading