-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate types for new MFD design #2455
Merged
Merged
Changes from 4 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
9c5be60
Multipart - generate type directly
timovv 51d1ed0
Rename type to contentType to match Core implementation
timovv fe180d6
e2e tests
timovv d7bbb59
Generate interfaces for parts in the array
timovv 804de8b
fixes
timovv 6bba312
Generate JSON array instead of multiple parts for JSON to satisfy cad…
timovv 42f1389
Merge branch 'main' into multipart-direct-generation
timovv f6f9930
@azure-rest/core-client@2.0.0
timovv 9c1a89d
Integration tests to 2.0.0
timovv e58f5d3
Fix rlc-common unit tests
timovv f7990c7
Use older core-clietn for swagger gen
timovv 23dda1d
rush update
timovv adaa2bc
Update autorest.typescript core client version
timovv 6b5d840
Revert "Update autorest.typescript core client version"
timovv 0f7ccb5
Use old core-client for Swagger
timovv 7673232
Disable new MFD for modular
timovv f0d9cc1
Make modular depend on old core-client
timovv 514ffbe
Fix bug
timovv 7ee574b
Revert "Make modular depend on old core-client"
timovv 8f9fefb
Update snapshots
timovv 3484daf
update faceai smoke test
kazrael2119 efcae26
rerun smoke-test
kazrael2119 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we consider the case for
A extends B
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not currently but we can revisit if this becomes a requirement