use dev-tool run extract-api in packages generated for JS mono repo
#2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the commit in JS repo: Azure/azure-sdk-for-js@224f7c1
jeremymeng
requested review from
sarangan12,
joheredi,
qiaozha and
MaryGao
as code owners
MaryGao
reviewed
Apr 22, 2024
| @@ -185,6 +185,7 @@ function regularAutorestPackage( | |||
| packageInfo.devDependencies["@azure/dev-tool"] = "^1.0.0"; | |||
| packageInfo.scripts["build"] = | |||
| "npm run clean && tsc && dev-tool run bundle && npm run minify && mkdirp ./review && npm run extract-api"; | |||
| packageInfo.scripts["extract-api"] = "dev-tool run extract-api"; | |||
There was a problem hiding this comment.
May I know if we need to switch all actions to dev-tool?
There was a problem hiding this comment.
For the JS monorepo we would prefer the consistent and centralized dev-tool command. It adds support for the subpath exports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the commit in JS repo: Azure/azure-sdk-for-js@224f7c1