Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize-name-in-interface-and-type-alias #2483

Merged
merged 7 commits into from
Apr 29, 2024
Merged

normalize-name-in-interface-and-type-alias #2483

merged 7 commits into from
Apr 29, 2024

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Apr 28, 2024 •
edited
Loading

fixes #2350
fixes #2482

@qiaozha
Copy link
Member Author

qiaozha commented Apr 29, 2024 •
edited
Loading

Should we also normalize the model name here https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-test/test/hierarchy_generic/generated/typespec-ts/src/models/models.ts#L12 ? RLC has done that https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-test/test/hierarchy_generic/generated/typespec-ts/src/rest/models.ts#L12

@joheredi, any suggestions?

@qiaozha qiaozha marked this pull request as ready for review April 29, 2024 06:08
@qiaozha
Copy link
Member Author

qiaozha commented Apr 29, 2024

Should we also normalize the model name here https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-test/test/hierarchy_generic/generated/typespec-ts/src/models/models.ts#L12 ? RLC has done that https://github.com/Azure/autorest.typescript/blob/main/packages/typespec-test/test/hierarchy_generic/generated/typespec-ts/src/rest/models.ts#L12

@joheredi, any suggestions?

I don't think we should block on this for now, as we have another issue to track this #2086

MaryGao
MaryGao approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiaozha @MaryGao
Update packages/typespec-ts/test/modularUnit/enumUnion.spec.ts
bfd2ce4 
Co-authored-by: Mary Gao <yanmeigao1210@gmail.com>
@qiaozha qiaozha merged commit 0362739 into Azure:main Apr 29, 2024
14 checks passed
@qiaozha qiaozha deleted the normalize-name-in-interface-and-type-alias branch April 29, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirenhe lirenhe lirenhe approved these changes

@MaryGao MaryGao MaryGao approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@qiaozha @lirenhe @MaryGao