Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkanalytics with modular #2536

Merged
merged 8 commits into from
May 23, 2024
Merged

networkanalytics with modular #2536

merged 8 commits into from
May 23, 2024

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented May 21, 2024 •
edited by MaryGao
Loading

fixes #2535
fixes #2353

@kazrael2119 kazrael2119 marked this pull request as ready for review May 23, 2024 07:31
qiaozha
qiaozha reviewed May 23, 2024
View reviewed changes
packages/typespec-test/test/openai_generic/generated/typespec-ts/src/models/models.ts
}

export interface ChatCompletionFunctionParameters
extends Record<string, unknown> {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should treat unknown as any?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use #2078 to track it.

@qiaozha qiaozha merged commit bca289d into Azure:main May 23, 2024
14 checks passed
@MaryGao MaryGao mentioned this pull request May 23, 2024
Closed
@kazrael2119 kazrael2119 deleted the networkanalytics branch May 23, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao left review comments

@qiaozha qiaozha qiaozha approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kazrael2119 @MaryGao @qiaozha