Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bearer to Bearer #2576

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Update bearer to Bearer #2576

merged 6 commits into from
Jun 13, 2024

Conversation

MaryGao
Copy link
Member

@MaryGao MaryGao commented Jun 13, 2024

fixes #2572
fixes #2109

@MaryGao MaryGao changed the title Update the changes Update bearer to Bearer Jun 13, 2024
@MaryGao MaryGao marked this pull request as ready for review June 13, 2024 08:07
securityInfo.customHttpAuthSharedKeyPrefix = auth.scheme;
// If it is basic or bearer auth we should generate it as Basic or Bearer
securityInfo.customHttpAuthSharedKeyPrefix = [
"basic",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do we set Basic now?

Copy link
Member Author

@MaryGao MaryGao Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should be the same as bearer in header.

https://swagger.io/docs/specification/authentication/basic-authentication/

Authorization: Basic ZGVtbzpwQDU1dzByZA==

Bearer

https://swagger.io/docs/specification/authentication/bearer-authentication/

Authorization: Bearer <token>

Copy link
Member

@qiaozha qiaozha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryGao MaryGao merged commit ed17e14 into Azure:main Jun 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TS] [DPG] BearerAuth generates lower case "bearer <key>" Bearer auth scheme is lowercase in request header
2 participants