Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mgmt Mongo Cluster #2581

Closed
wants to merge 11 commits into from
Closed

Add Mgmt Mongo Cluster #2581

wants to merge 11 commits into from

Conversation

v-jiaodi
Copy link
Member

Pass

@kazrael2119
Copy link
Contributor

kazrael2119 commented Jun 18, 2024 •
edited
Loading

operation name change: beginXXX & beginXXXAndWait -> XXX
operations have a new parameter subscriptionId
Interface XXXOptionalParams no longer has parameter resumeFrom
client name chanaged
removed enum
removed XXXResponse

@kazrael2119
Copy link
Contributor

different promiss model between hlc and modular:
https://github.com/Azure/autorest.typescript/pull/2581/files#diff-4b604745b828f172967e4f4fce6011caf7ee649de8665f5167bdf9c65358f74fR36

https://github.com/kazrael2119/azure-sdk-for-js/blob/mongcluster-re/sdk/mongocluster/arm-mongocluster/src/operationsInterfaces/firewallRules.ts#L63-L66

tsp link:

autorest.typescript/packages/typespec-test/test/DocumentDB.MongoCluster.Management/spec/FirewallRule.tsp

Lines 39 to 47 in eb4289e

/** Creates a new firewall rule or updates an existing firewall rule on a mongo cluster. */
#suppress "@azure-tools/typespec-azure-resource-manager/arm-put-operation-response-codes" "Need to support existing 202 response for PUT operations"
createOrUpdate is ArmResourceCreateOrReplaceAsync<
FirewallRule,
Response = ArmAcceptedLroResponse<"Resource operation accepted."> | ArmResourceUpdatedResponse<FirewallRule> | ArmResourceCreatedResponse<
FirewallRule,
LroHeaders = {}
>
>;

MaryGao
MaryGao reviewed Jun 19, 2024
View reviewed changes
...st/test/DocumentDB.MongoCluster.Management/generated/typespec-ts/src/api/operations/index.ts Outdated
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

import { PagedOperation, Operation } from "../../models/models.js";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not export to top-level index.

MaryGao
MaryGao reviewed Jun 26, 2024
View reviewed changes
...t/test/DocumentDB.MongoCluster.Management/generated/typespec-ts/src/api/documentDBContext.ts Outdated

/** The Microsoft Azure management API provides create, read, update, and delete functionality for Azure Cosmos DB for MongoDB vCore resources including clusters and firewall rules. */
export function createDocumentDB(
credential: TokenCredential,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no apiVersion parameter.

@MaryGao MaryGao self-assigned this Jul 1, 2024
@qiaozha
Copy link
Member

qiaozha commented Jul 10, 2024

close it as no need for this now.

@qiaozha qiaozha closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaryGao MaryGao MaryGao left review comments

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 will be requested when the pull request is marked ready for review sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi will be requested when the pull request is marked ready for review joheredi is a code owner

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha will be requested when the pull request is marked ready for review qiaozha is a code owner

Assignees

@MaryGao MaryGao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-jiaodi @kazrael2119 @qiaozha @MaryGao