Modular: Encapsulate serializers into functions

packages/rlc-common/src/helpers/importsUtil.ts

@@ -90,6 +90,10 @@ export function initInternalImports(): Imports {
     rlcClientDefinition: {
       type: "rlcClientDefinition",
       importsSet: new Set<string>()
+    },
+    serializerHelpers: {
+      type: "serializerHelpers",
+      importsSet: new Set<string>()
     }
   } as Imports;
 }
@@ -155,6 +159,9 @@ export function addImportsToFiles(
       const specifier =
         internalSpecifierMap?.[importType.type] ?? importType.specifier!;
       let hasModifier = false;
+      if (!specifier) {
+        return;
+      }
       file
         .getImportDeclarations()
         .filter((importDeclaration) => {

packages/rlc-common/src/interfaces.ts

@@ -46,7 +46,9 @@ export type ImportType =
   | "azureDevTool"
   | "azureAbortController"
   | "azureCoreLro"
-  | "azureCorePaging";
+  | "azureCorePaging"
+  /**Internal helper imports */
+  | "serializerHelpers";
 
 export interface ImportMetadata {
   type: ImportType;

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataProducts/index.ts

@@ -4,6 +4,9 @@
 import { getLongRunningPoller } from "../pollingHelpers.js";
 import { PollerLike, OperationState } from "@azure/core-lro";
 import {
+  dataProductPropertiesSerializer,
+  managedServiceIdentitySerializer,
+  dataProductUpdatePropertiesSerializer,
   DataProduct,
   DataProductUpdate,
   AccountSas,
@@ -53,6 +56,7 @@ import {
   operationOptionsToRequestParameters,
   createRestError,
 } from "@azure-rest/core-client";
+import { serializeRecord } from "../../helpers/serializerHelpers.js";
 import {
   DataProductsCreateOptionalParams,
   DataProductsGetOptionalParams,
@@ -90,76 +94,16 @@ export function _createSend(
     .put({
       ...operationOptionsToRequestParameters(options),
       body: {
-        tags: resource["tags"],
+        tags: !resource.tags
+          ? resource.tags
+          : (serializeRecord(resource.tags as any) as any),
         location: resource["location"],
         properties: !resource.properties
-          ? undefined
-          : {
-              publisher: resource.properties?.["publisher"],
-              product: resource.properties?.["product"],
-              majorVersion: resource.properties?.["majorVersion"],
-              owners: resource.properties?.["owners"],
-              redundancy: resource.properties?.["redundancy"],
-              purviewAccount: resource.properties?.["purviewAccount"],
-              purviewCollection: resource.properties?.["purviewCollection"],
-              privateLinksEnabled: resource.properties?.["privateLinksEnabled"],
-              publicNetworkAccess: resource.properties?.["publicNetworkAccess"],
-              customerManagedKeyEncryptionEnabled:
-                resource.properties?.["customerManagedKeyEncryptionEnabled"],
-              customerEncryptionKey: !resource.properties?.customerEncryptionKey
-                ? undefined
-                : {
-                    keyVaultUri:
-                      resource.properties?.customerEncryptionKey?.[
-                        "keyVaultUri"
-                      ],
-                    keyName:
-                      resource.properties?.customerEncryptionKey?.["keyName"],
-                    keyVersion:
-                      resource.properties?.customerEncryptionKey?.[
-                        "keyVersion"
-                      ],
-                  },
-              networkacls: !resource.properties?.networkacls
-                ? undefined
-                : {
-                    virtualNetworkRule: resource.properties?.networkacls?.[
-                      "virtualNetworkRule"
-                    ].map((p) => ({
-                      id: p["id"],
-                      action: p["action"],
-                      state: p["state"],
-                    })),
-                    ipRules: resource.properties?.networkacls?.["ipRules"].map(
-                      (p) => ({ value: p["value"], action: p["action"] }),
-                    ),
-                    allowedQueryIpRangeList:
-                      resource.properties?.networkacls?.[
-                        "allowedQueryIpRangeList"
-                      ],
-                    defaultAction:
-                      resource.properties?.networkacls?.["defaultAction"],
-                  },
-              managedResourceGroupConfiguration: !resource.properties
-                ?.managedResourceGroupConfiguration
-                ? undefined
-                : {
-                    name: resource.properties
-                      ?.managedResourceGroupConfiguration?.["name"],
-                    location:
-                      resource.properties?.managedResourceGroupConfiguration?.[
-                        "location"
-                      ],
-                  },
-              currentMinorVersion: resource.properties?.["currentMinorVersion"],
-            },
+          ? resource.properties
+          : dataProductPropertiesSerializer(resource.properties),
         identity: !resource.identity
-          ? undefined
-          : {
-              type: resource.identity?.["type"],
-              userAssignedIdentities:
-                resource.identity?.["userAssignedIdentities"],
-            },
+          ? resource.identity
+          : managedServiceIdentitySerializer(resource.identity),
       },
     });
 }
@@ -518,24 +462,14 @@ export function _updateSend(
       ...operationOptionsToRequestParameters(options),
       body: {
         identity: !properties.identity
-          ? undefined
-          : {
-              type: properties.identity?.["type"],
-              userAssignedIdentities:
-                properties.identity?.["userAssignedIdentities"],
-            },
-        tags: properties["tags"],
+          ? properties.identity
+          : managedServiceIdentitySerializer(properties.identity),
+        tags: !properties.tags
+          ? properties.tags
+          : (serializeRecord(properties.tags as any) as any),
         properties: !properties.properties
-          ? undefined
-          : {
-              owners: properties.properties?.["owners"],
-              purviewAccount: properties.properties?.["purviewAccount"],
-              purviewCollection: properties.properties?.["purviewCollection"],
-              privateLinksEnabled:
-                properties.properties?.["privateLinksEnabled"],
-              currentMinorVersion:
-                properties.properties?.["currentMinorVersion"],
-            },
+          ? properties.properties
+          : dataProductUpdatePropertiesSerializer(properties.properties),
       },
     });
 }

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/api/dataTypes/index.ts

@@ -4,6 +4,8 @@
 import { getLongRunningPoller } from "../pollingHelpers.js";
 import { PollerLike, OperationState } from "@azure/core-lro";
 import {
+  dataTypePropertiesSerializer,
+  dataTypeUpdatePropertiesSerializer,
   DataType,
   DataTypeUpdate,
   ContainerSaS,
@@ -79,15 +81,8 @@ export function _createSend(
       ...operationOptionsToRequestParameters(options),
       body: {
         properties: !resource.properties
-          ? undefined
-          : {
-              state: resource.properties?.["state"],
-              storageOutputRetention:
-                resource.properties?.["storageOutputRetention"],
-              databaseCacheRetention:
-                resource.properties?.["databaseCacheRetention"],
-              databaseRetention: resource.properties?.["databaseRetention"],
-            },
+          ? resource.properties
+          : dataTypePropertiesSerializer(resource.properties),
       },
     });
 }
@@ -274,15 +269,8 @@ export function _updateSend(
       ...operationOptionsToRequestParameters(options),
       body: {
         properties: !properties.properties
-          ? undefined
-          : {
-              state: properties.properties?.["state"],
-              storageOutputRetention:
-                properties.properties?.["storageOutputRetention"],
-              databaseCacheRetention:
-                properties.properties?.["databaseCacheRetention"],
-              databaseRetention: properties.properties?.["databaseRetention"],
-            },
+          ? properties.properties
+          : dataTypeUpdatePropertiesSerializer(properties.properties),
       },
     });
 }

packages/typespec-test/test/NetworkAnalytics.Management/generated/typespec-ts/src/helpers/serializerHelpers.ts

@@ -0,0 +1,40 @@
+// Copyright (c) Microsoft Corporation.
+// Licensed under the MIT license.
+
+export function serializeRecord<
+  T extends string | number | boolean | Date | null,
+  R,
+>(item: Record<string, T>): Record<string, R>;
+export function serializeRecord<T, R>(
+  item: Record<string, T>,
+  serializer: (item: T) => R,
+): Record<string, R>;
+export function serializeRecord<T, R>(
+  item: Record<string, T>,
+  serializer?: (item: T) => R,
+): Record<string, R> {
+  return Object.keys(item).reduce(
+    (acc, key) => {
+      if (isSupportedRecordType(item[key])) {
+        acc[key] = item[key] as any;
+      } else if (serializer) {
+        const value = item[key];
+        if (value !== undefined) {
+          acc[key] = serializer(value);
+        }
+      } else {
+        console.warn(`Don't know how to serialize ${item[key]}`);
+        acc[key] = item[key] as any;
+      }
+      return acc;
+    },
+    {} as Record<string, R>,
+  );
+}
+
+function isSupportedRecordType(t: any) {
+  return (
+    ["number", "string", "boolean", "null"].includes(typeof t) ||
+    t instanceof Date
+  );
+}