Handle nullable dictionaries in modular #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
changed the title
MaryGao
commented
Jul 2, 2024
| @@ -668,7 +668,7 @@ export interface CreateCompletionRequest { | |||
| * between -1 and 1 should decrease or increase likelihood of selection; values like -100 or 100 | |||
| * should result in a ban or exclusive selection of the relevant token. | |||
| */ | |||
| logitBias?: Record<string, number>; | |||
| logitBias?: Record<string, number> | null; | |||
There was a problem hiding this comment.
This issue isn't raised up because this happened in input model so converting Record<string, number> to Record<string, number> | null will have no issue.
But we would have compile error if happened for output models.
There was a problem hiding this comment.
Not related to this pr but I found the original typespec is
logit_bias?: Record<safeint> | null; and there's no @clientName decorator, we just automatically normalize the name in Modular layer, wonder if that's expected?
There was a problem hiding this comment.
interesting finding, i created an issue for that #2645. let's talk there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the nullable dictionary in modular.
fix the azure fleet build issue.