Upgrade compiler and tcgc in Aug #2741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
reviewed
Aug 12, 2024
| @@ -90,6 +90,7 @@ | |||
| } | |||
| }, | |||
| "requestBody": { | |||
| "required": true, | |||
There was a problem hiding this comment.
Should be a fix in OpenAPI emitter with shared route: microsoft/typespec#4044
MaryGao
reviewed
Aug 12, 2024
| @@ -501,7 +501,7 @@ export interface Embedding { | |||
| object: "embedding"; | |||
| /** | |||
| * The embedding vector, which is a list of floats. The length of vector depends on the model as\ | |||
| * * listed in the [embedding guide](/docs/guides/embeddings). | |||
| * listed in the [embedding guide](/docs/guides/embeddings). | |||
There was a problem hiding this comment.
The change should be expected and fixed here: microsoft/typespec#3646.
which means the nightly ci would be expected to be failed.
qiaozha
approved these changes
Aug 12, 2024
qiaozha
reviewed
Aug 12, 2024
| @@ -1,43 +1,44 @@ | |||
| lockfileVersion: 5.4 | |||
|
|
|||
| importers: | |||
|
|
|||
There was a problem hiding this comment.
why do we have 7927 lines changes for this file ?
There was a problem hiding this comment.
i think this is because of format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2740
Upgrade compiler version to
v0.59.0Upgrade tcgc version to
v0.45.1