This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Include cluster creation time in output of cluster list and cluster get #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeguerin
suggested changes
Nov 1, 2018
aztk_cli/utils.py
Outdated
| @@ -50,6 +50,7 @@ def print_cluster(client, cluster: models.Cluster, internal: bool = False): | |||
| log.info("------------------------------------------") | |||
| log.info("State: %s", cluster.state.value) | |||
| log.info("Node Size: %s", cluster.vm_size) | |||
| log.info("Created: %s", cluster.pool.creation_time.strftime('%Y-%m-%d %H:%M:%S')) | |||
There was a problem hiding this comment.
can you make an helper function for converting the date to string so we only provide the format once?
There was a problem hiding this comment.
Sure. I didn't include the seconds in the table listing to keep the width down, so added a parameter for that, but can remove it if you'd prefer to keep it simple.
timotheeguerin
approved these changes
Nov 1, 2018
|
@emlyn Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When listing clusters I find it's useful to have the creation time in order to differentiate between similar clusters (e.g. to shut down the older one), or to make it easier to spot clusters that have been unintentionally left running.
What do you think?